Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Adapter for RecommendationItem to serialize and deserialize the enum #1321

Closed

Conversation

bharathappali
Copy link
Member

Description

This PR is seventh part of the set of PR's which will be raised for adding GPU support #1312

This PR adds adapter for RecommendationItem to serialize and deserialize the enum

This PR is build on top of #1320, so it needs to be merged after merging #1320

Fixes #1312

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes

How has this been tested?

Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

  • New Test X
  • Functional testsuite

Test Configuration

  • Kubernetes clusters tested on:

Checklist 🎯

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

Include any additional information such as links, test results, screenshots here

Signed-off-by: bharathappali <abharath@redhat.com>
@dinogun
Copy link
Contributor

dinogun commented Oct 8, 2024

Please fix the build_crc PR check, this cannot be merged as-is

@bharathappali
Copy link
Member Author

Fixes are added in #1324 This PR is no longer needed.

@dinogun dinogun removed this from the Kruize 0.1 Release milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants