Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds and refactors for Triton FIL examples #7

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

rafvasq
Copy link
Member

@rafvasq rafvasq commented Jan 26, 2024

Related to kserve/modelmesh-serving#485 and kserve/modelmesh-serving#185, this PR expands on lightgbm and xgboost examples to show that they can be deployed with Triton (in addition to MLServer).

Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rafvasq -- just 2 little nits

lightgbm/lightgbm-fil/config.pbtxt Outdated Show resolved Hide resolved
xgboost/mushroom-fil/config.pbtxt Outdated Show resolved Hide resolved
@rafvasq rafvasq requested a review from ckadner February 28, 2024 20:29
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ckadner
Copy link
Member

ckadner commented Mar 5, 2024

/approve

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@oss-prow-bot oss-prow-bot bot added the lgtm label Mar 5, 2024
Copy link

oss-prow-bot bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit 8311c22 into kserve:main Mar 5, 2024
3 checks passed
@rafvasq rafvasq deleted the add-triton-fil-models branch March 5, 2024 20:03
@ckadner
Copy link
Member

ckadner commented Mar 5, 2024

Thanks @rafvasq

rafvasq added a commit to kserve/modelmesh-serving that referenced this pull request Mar 13, 2024
#### Motivation
Triton introduced [support for more model frameworks last
year](https://developer.nvidia.com/blog/real-time-serving-for-xgboost-scikit-learn-randomforest-lightgbm-and-more/)
and can support xgboost, lightgbm, and more. This PR adds examples and
docs to advertise this.

#### Modifications
- Add newly supported models to Triton runtime config, setting
`autoSelect: false`.
- Add an example ISVC config for Triton-served XGBoost model.
- Update example-models doc to reflect example models added in
kserve/modelmesh-minio-examples#7
- Update model-formats README to reflect framework support and
framework-specific docs to show example ISVC using Triton.
- Add FVTs for lightgbm and xgboost deployment on Triton runtime

#### Result
Closes #185

---------

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
zhlsunshine pushed a commit to zhlsunshine/modelmesh-serving that referenced this pull request Mar 22, 2024
#### Motivation
Triton introduced [support for more model frameworks last
year](https://developer.nvidia.com/blog/real-time-serving-for-xgboost-scikit-learn-randomforest-lightgbm-and-more/)
and can support xgboost, lightgbm, and more. This PR adds examples and
docs to advertise this.

#### Modifications
- Add newly supported models to Triton runtime config, setting
`autoSelect: false`.
- Add an example ISVC config for Triton-served XGBoost model.
- Update example-models doc to reflect example models added in
kserve/modelmesh-minio-examples#7
- Update model-formats README to reflect framework support and
framework-specific docs to show example ISVC using Triton.
- Add FVTs for lightgbm and xgboost deployment on Triton runtime

#### Result
Closes kserve#185

---------

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants