Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the MLServer runtime be replaced by Triton? #185

Closed
OvervCW opened this issue Jul 11, 2022 · 3 comments · Fixed by #485
Closed

Can the MLServer runtime be replaced by Triton? #185

OvervCW opened this issue Jul 11, 2022 · 3 comments · Fixed by #485
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers question Further information is requested

Comments

@OvervCW
Copy link

OvervCW commented Jul 11, 2022

ModelMesh currently uses the MLServer runtime to serve sklearn, xgboost, and lightgbm models. However, it seems like recent versions of Triton now support all of those model types as well.

Does that mean that ModelMesh could support all types of models using a single runtime? And if so, would it be easy to change the adapter to handle this?

@njhill
Copy link
Member

njhill commented Jul 22, 2022

@OvervCW there shouldn't be anything stopping you using these other kinds of models with Triton, would be great if you could try it out!

Hopefully all that should be needed is to:

  • Update the triton-2.x ServingRuntime spec to include additional supportedModelFormats as needed
  • Reference the appropriate type in your Predictor and either specify the runtime name explicitly or delete/remove other runtimes like MLServer which also support the same type (or set autoSelect to false in the right places in those other runtimes)
  • Make sure to include a full Triton model configuration pbtxt file in the storage location that the Predictor's path points to (like this)

@njhill njhill added the question Further information is requested label Jul 22, 2022
@ckadner ckadner added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jan 20, 2024
@ckadner
Copy link
Member

ckadner commented Jan 20, 2024

@rafvasq -- since you updated the Triton serving runtime last year, it might be worth trying this out and documenting it. WDYT?

@rafvasq
Copy link
Member

rafvasq commented Jan 26, 2024

@ckadner I confirmed that with a few changes, Triton's able to deploy those models too. Think it'd be worth updating the docs to reflect that which includes a couple of small updates to the example models via kserve/modelmesh-minio-examples#7.

ckadner pushed a commit to kserve/modelmesh-minio-examples that referenced this issue Mar 5, 2024
Related to kserve/modelmesh-serving#485 and
kserve/modelmesh-serving#185, this PR expands
on `lightgbm` and `xgboost` examples to show that they can be deployed
with Triton (in addition to MLServer).

---------

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
rafvasq added a commit that referenced this issue Mar 13, 2024
#### Motivation
Triton introduced [support for more model frameworks last
year](https://developer.nvidia.com/blog/real-time-serving-for-xgboost-scikit-learn-randomforest-lightgbm-and-more/)
and can support xgboost, lightgbm, and more. This PR adds examples and
docs to advertise this.

#### Modifications
- Add newly supported models to Triton runtime config, setting
`autoSelect: false`.
- Add an example ISVC config for Triton-served XGBoost model.
- Update example-models doc to reflect example models added in
kserve/modelmesh-minio-examples#7
- Update model-formats README to reflect framework support and
framework-specific docs to show example ISVC using Triton.
- Add FVTs for lightgbm and xgboost deployment on Triton runtime

#### Result
Closes #185

---------

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
zhlsunshine pushed a commit to zhlsunshine/modelmesh-serving that referenced this issue Mar 22, 2024
#### Motivation
Triton introduced [support for more model frameworks last
year](https://developer.nvidia.com/blog/real-time-serving-for-xgboost-scikit-learn-randomforest-lightgbm-and-more/)
and can support xgboost, lightgbm, and more. This PR adds examples and
docs to advertise this.

#### Modifications
- Add newly supported models to Triton runtime config, setting
`autoSelect: false`.
- Add an example ISVC config for Triton-served XGBoost model.
- Update example-models doc to reflect example models added in
kserve/modelmesh-minio-examples#7
- Update model-formats README to reflect framework support and
framework-specific docs to show example ISVC using Triton.
- Add FVTs for lightgbm and xgboost deployment on Triton runtime

#### Result
Closes kserve#185

---------

Signed-off-by: Rafael Vasquez <raf.vasquez@ibm.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers question Further information is requested
Projects
None yet
4 participants