-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Payload logging/events #284
Comments
Hi @njhill , what is the definition of payload logging here, does it include the logs in the runtime level? If not, is it possible to support it like adding a model_id identifier in the log line so that we can filter it per inferenceSerivce. Currently we plan to expose the logs (runtime logs) on the servingRuntime level (actual deployment) as the inferenceService (model) is kind of a logical concept in modelmesh. However, in standard KServe flow, we expose the logs per inferenceService. If logging per inferenceService is possible in ModelMesh, it will be good to align the user experience. Thanks. |
@lizzzcai noticing your question here after a long time, sorry about that. This issue isn't about program logs, rather about the ability to send the contents of every request and response somewhere configurable (so that it can be logged/stored/analysed as needed). |
…predictions (#84) #### Motivation This PR seeks to address the model-mesh side of kserve/modelmesh-serving#284. #### Modifications It provides a `PayloadProcessor` interface. `PayloadProcessors` are picked by `ModelMesh` instances at startup and predictions (`Payloads`) are processed asynchronously at fixed timing. A first logger implementation allows to log `Payloads` (at _info_ level). #### Result A SPI for post processing model predictions. --- resolves kserve/modelmesh-serving#284 Signed-off-by: Tommaso Teofili <tteofili@redhat.com>
I was just revisiting some features in the ModelMesh v0.11.0 release to draft a release blog. Re: CloudEvents ...
As best as I can tell, this is not part of the implementation on kserve/modelmesh#84 but it could now be implemented as one new |
For various reasons including monitoring by external system for things like drift / outlier detection etc.
It should support CloudEvents and be compatible with the logger in KServe "classic", so that it can be used in a similar way, as illustrated in these samples:
Some considerations / possible complications:
cc @rafvasq
The text was updated successfully, but these errors were encountered: