Add support for configurable MM_Payload_Processor environment variable #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: robgeada <rob@geada.net>
RobGeada
force-pushed
the
PayloadProcessorEndpointConfig
branch
from
07c0184 to
ccac775
Compare
Signed-off-by: robgeada <rob@geada.net>
6 tasks
Signed-off-by: robgeada <rob@geada.net>
RobGeada
force-pushed
the
PayloadProcessorEndpointConfig
branch
from
1741855 to
ab45d5c
Compare
|
@njhill, comments addressed! |
Signed-off-by: robgeada <rob@geada.net>
RobGeada
force-pushed
the
PayloadProcessorEndpointConfig
branch
from
929d822 to
5e529ad
Compare
Signed-off-by: robgeada <rob@geada.net>
njhill
approved these changes
Mar 16, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhill, RobGeada The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
ckadner
added a commit
to ckadner/modelmesh-serving
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
VedantMahabaleshwarkar
pushed a commit
to VedantMahabaleshwarkar/modelmesh-serving
that referenced
this pull request
Mar 20, 2023
kserve#339) #### Motivation In order to integrate with the upcoming [ModelMesh payload processing feature](kserve/modelmesh#84 (comment)), the MM_PAYLOAD_PROCESSOR environment variable within the ModelMesh image needs to point at the endpoint of the payload processing service within the cluster. By setting this as a variable set in the config.yaml, it allows for a variety of payload processing or logging services to be plugged in via the deployment manifest. #### Modifications - Added PayloadProcessor field to the `controllers/mmesh/modelmesh.go` Deployment struct - Added PayloadProcessor field to the `pkg/config/config.go` Config struct - Added default setting of this field to an empty string within `pkg/config/config.go` - Added functions in `controllers/suite_text.go` to load a config file that specifies the Payload processor - these tests ensure the default value of `MM_PAYLOAD_PROCESSOR` is empty, while it receives the correct value if such a field is present in the config yaml file #### Result - Ability to set MM_PAYLOAD_PROCESSOR env variable via config.yaml - If no such variable is set, the only effect is the ModelMesh image receives an empty env var Signed-off-by: robgeada <rob@geada.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to integrate with the upcoming ModelMesh payload processing feature, the MM_PAYLOAD_PROCESSOR environment variable within the ModelMesh image needs to point at the endpoint of the payload processing service within the cluster. By setting this as a variable set in the config.yaml, it allows for a variety of payload processing or logging services to be plugged in via the deployment manifest.
Modifications
controllers/mmesh/modelmesh.goDeployment structpkg/config/config.goConfig structpkg/config/config.gocontrollers/suite_text.goto load a config file that specifies the Payload processorMM_PAYLOAD_PROCESSORis empty, while it receives the correct value if such a field is present in the config yaml fileResult
Resolves #284