feat: Supports image pull secrets #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizzzcai
force-pushed
the
feat-sr-add-image-pull-secrets-1105
branch
from
04afe39 to
0bc36e0
Compare
Signed-off-by: Lize Cai <lize.cai@sap.com>
lizzzcai
force-pushed
the
feat-sr-add-image-pull-secrets-1105
branch
from
0bc36e0 to
0033e3e
Compare
|
@njhill , could you help to review this PR? thanks. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lizzzcai, njhill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
HumairAK
referenced
this pull request
in HumairAK/modelmesh-serving
Nov 30, 2022
#### Motivation fix opendatahub-io#214 #### Modifications 1. Update servingRuntime CRDs to include imagePullSecrets 2. pass imagePullSecrets from Configuration and ServingRuntimePodSpec to deployment.Spec.Template and add tests 3. add docs in Configuration #### Result The user is able to pass imagePullSecrets from configuration and servingRuntime to runtime pod and uses images from the private image registry. Signed-off-by: Lize Cai <lize.cai@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fix #214
Modifications
Result
The user is able to pass imagePullSecrets from configuration and servingRuntime to runtime pod and uses images from the private image registry.