Skip to content

Commit

Permalink
Allow custom ServingRuntimes (#92)
Browse files Browse the repository at this point in the history
* Allow custom ServingRuntimes

Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>

* Added prettier check to makefile

Signed-off-by: Hansini Karunarathne <107214435+hansinikarunarathne@users.noreply.github.com>

* formated

Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>

---------

Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>
Signed-off-by: Hansini Karunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Co-authored-by: Salomon Popp <salomon.popp@bakdata.com>
  • Loading branch information
hansinikarunarathne and disrupted authored Sep 3, 2024
1 parent 07644a3 commit 4675bb9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ IMG ?= kserve/models-web-app
TAG ?= $(shell git describe --tags --always --dirty)
ARCH ?= linux/amd64

# Prettier UI format check.
prettier-check:
npm run format:check --prefix frontend


docker-build:
docker build -t ${IMG}:${TAG} .
Expand Down
9 changes: 1 addition & 8 deletions frontend/src/app/shared/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,7 @@ export function getPredictorExtensionSpec(
predictor: PredictorSpec,
): PredictorExtensionSpec {
if (predictor.model) {
if (
Object.values(PredictorType).includes(
predictor.model?.modelFormat.name as PredictorType,
)
) {
const spec = predictor.model;
return spec;
}
return predictor.model;
} else {
for (const predictorType of Object.values(PredictorType)) {
if (predictorType in predictor) {
Expand Down

0 comments on commit 4675bb9

Please sign in to comment.