Allow custom ServingRuntimes

[hansinikarunarathne]

fix issue with #47 PR

[hansinikarunarathne]

@juliusvonkohout can you please review this? Then I can fix the other two PRs which give the same issue.

[juliusvonkohout]

I see

 make: *** No rule to make target 'prettier-check'.  Stop.
Error: Process completed with exit code 2.

[hansinikarunarathne]

I see

 make: *** No rule to make target 'prettier-check'.  Stop.
Error: Process completed with exit code 2.

can you run it again @juliusvonkohout

[juliusvonkohout]

@hansinikarunarathne can you test this image once with our kserve workflow and check whether it works in the UI? https://github.com/kubeflow/manifests/blob/master/.github/workflows/kserve_m2m_test.yaml
please upload a screenshot

[juliusvonkohout]

/ok-to-test

[hansinikarunarathne]

@juliusvonkohout can you please approve to run the test

[hansinikarunarathne]

@hansinikarunarathne can you test this image once with our kserve workflow and check whether it works in the UI? https://github.com/kubeflow/manifests/blob/master/.github/workflows/kserve_m2m_test.yaml please upload a screenshot

can you explain this bit more ?

[hansinikarunarathne]

If there is no any concerns regarding this PR, please approve this

[juliusvonkohout]

/lgtm
/approve

[juliusvonkohout]

@hansinikarunarathne did you not test this locally as discussed? otherwise i have to revert it.

[juliusvonkohout]

Please create a PR to revert the change (keep the test fixes) if it does not pass the tests https://github.com/kubeflow/manifests/blob/master/.github/workflows/kserve_m2m_test.yaml and https://github.com/kubeflow/manifests/blob/master/.github/workflows/kserve_test.yaml

It should be in the workflows above and here is the explicit file
kserve_test.yaml

They reported issues here with the PR #47 (comment) and you need to make sure that there is no regression.