Upgrade turndownschedules CRD to apiextensions v1 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apiextensions.k8s.io/v1beta1 is removed as of K8s v1.22 [1], so all CRDs have to be updated to apiextensions.k8s.io/v1. This commit does the upgrade for the turndownschedule CRD. As part of the API updates, K8s is enforcing things grouped under *.k8s.io to be approved [2] because they are actually supposed to be Kuberenetes community-managed APIs [3]. So this commit also changes the CRD from: turndownschedules.kubecost.k8s.io to turndownschedules.kubecost.com This is in-line with K8s rules and links to our main domain. Tested by applying cluster-turndown-full.yaml and example-schedule.yaml successfully. [1] https://cloud.google.com/kubernetes-engine/docs/deprecations/apis-1-22 [2] kubernetes/enhancements#1111 [3] kubernetes/enhancements#1111 (comment)
mbolt35
approved these changes
May 27, 2022
Yes, unfortunately it does. This requires a major version update and a breaking change notification in the release notes. |
michaelmdresser
added a commit
to kubecost/cost-analyzer-helm-chart
that referenced
this pull request
May 27, 2022
v2 of turndown changes the namespacing of the turndown resources to match K8s API policy. See discussion and references in kubecost/cluster-turndown#44 for more detail. The new CRD YAML is copied from cluster-turndown v2.0.1
michaelmdresser
added a commit
to kubecost/cost-analyzer-helm-chart
that referenced
this pull request
Jun 2, 2022
v2 of turndown changes the namespacing of the turndown resources to match K8s API policy. See discussion and references in kubecost/cluster-turndown#44 for more detail. The new CRD YAML is copied from cluster-turndown v2.0.1
michaelmdresser
added a commit
to kubecost/cost-analyzer-helm-chart
that referenced
this pull request
Jun 2, 2022
v2 of turndown changes the namespacing of the turndown resources to match K8s API policy. See discussion and references in kubecost/cluster-turndown#44 for more detail. The new CRD YAML is copied from cluster-turndown v2.0.1
AjayTripathy
added a commit
to kubecost/cost-analyzer-helm-chart
that referenced
this pull request
Jun 3, 2022
* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <ajay@kubecost.com> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * White List LoadBalancer Cost * Add kubecost_load_balancer_cost to Metric White List * Add logging to readme * add detail to helm install notes (#1418) * add detail to helm install notes * Add error_throttle_sleep to Grafana sidecar (#1413) * Add editor group to RBAC * apiextensions.k8s.io/v1beta1 to v1 * conditional api use * Remove duplicate 'RELEASE_NAME' env var * versioning fix * James/add pln support (#1433) * adds PLN language support * should restore formatting * formatting again * saved without formatting * selfsigned cert flags (#734) * selfsigned cert stuff * fix name of configmap * add selfsigned certs for all thanos deps * Document grafana.sidecar.dashboards.enabled and add to agent example (#1432) * Document grafana.sidecar.dashboards.enabled option in cost-analyzer chart * Update values-agent.yaml * Ajay tripathy etl readonly perms (#1421) * remove server block and associated values * fix conflicts * AjayTripathy-vmware * use flag to generate rbac templates * undo accidental change * add newline * remove empty file * fix templating name * fixes * Switch etlReadOnlyMode false * Bump to v1.94.0-rc.0 Commit auto-generated by release script. * Updated to have the context name description next to clusterName. (#1450) * Update cluster-controller to v0.1.0 This includes a BREAKING CHANGE to the cluster-turndown functionality that is wrapped by cluster-controller. The breaking changes are summarized in https://github.com/kubecost/cluster-turndown/releases/tag/v2.0.0 and should be featured prominently in release notes. * Update turndownschedules CRD for v2 of turndown v2 of turndown changes the namespacing of the turndown resources to match K8s API policy. See discussion and references in kubecost/cluster-turndown#44 for more detail. The new CRD YAML is copied from cluster-turndown v2.0.1 * Fix infinite redirect for users with no rbac roles * Pick etl-filestore-default for v1.94 (#1453) * Add etlFileStoreEnabled: true to values.yaml * Update helm chart to default to ETL file store * Bump to v1.94.0-rc.1 (#1458) Commit auto-generated by release script. Co-authored-by: keith.hand <keith@hand.technology> Co-authored-by: keith.hand <43491549+keithhand@users.noreply.github.com> Co-authored-by: keith.hand <rkeithhand@gmail.com> Co-authored-by: Kaelan Patel <kaelanspatel@gmail.com> Co-authored-by: Niko Kovacevic <nikovacevic@gmail.com> Co-authored-by: Naresh Agrawal <62406250+nareshagrawal@users.noreply.github.com> Co-authored-by: Cameron Hall <me@chall.id.au> Co-authored-by: Ajay Tripathy <ajay@kubecost.com> Co-authored-by: Volodymyr <vova3379@users.noreply.github.com> Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> Co-authored-by: Michael Dresser <michaelmdresser@gmail.com> Co-authored-by: dschunack <dschunack@web.de> Co-authored-by: Neal Ormsbee <neal.ormsbee@gmail.com> Co-authored-by: Daniel Ramich <dan@inngest.com> Co-authored-by: Dan Ramich <dramich@users.noreply.github.com> Co-authored-by: Sean Holcomb <seanholcomb@gmail.com> Co-authored-by: Matt Bolt <mbolt35@gmail.com> Co-authored-by: Kaelan Patel <32113845+kaelanspatel@users.noreply.github.com> Co-authored-by: Jesse Goodier <31039225+jessegoodier@users.noreply.github.com> Co-authored-by: Sean Pomeroy <sean.pomeroy@gmail.com> Co-authored-by: wolfeaustin <wolfe_austin@yahoo.com> Co-authored-by: Morten Mjelva <morten.mjelva@gmail.com> Co-authored-by: James Jarrett <jjarrett21@gmail.com> Co-authored-by: Brandon High <highb@users.noreply.github.com>
AjayTripathy
added a commit
to kubecost/cost-analyzer-helm-chart
that referenced
this pull request
Jun 7, 2022
* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <ajay@kubecost.com> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * White List LoadBalancer Cost * Add kubecost_load_balancer_cost to Metric White List * Add logging to readme * add detail to helm install notes (#1418) * add detail to helm install notes * Add error_throttle_sleep to Grafana sidecar (#1413) * Add editor group to RBAC * apiextensions.k8s.io/v1beta1 to v1 * conditional api use * Remove duplicate 'RELEASE_NAME' env var * versioning fix * James/add pln support (#1433) * adds PLN language support * should restore formatting * formatting again * saved without formatting * selfsigned cert flags (#734) * selfsigned cert stuff * fix name of configmap * add selfsigned certs for all thanos deps * Document grafana.sidecar.dashboards.enabled and add to agent example (#1432) * Document grafana.sidecar.dashboards.enabled option in cost-analyzer chart * Update values-agent.yaml * Ajay tripathy etl readonly perms (#1421) * remove server block and associated values * fix conflicts * AjayTripathy-vmware * use flag to generate rbac templates * undo accidental change * add newline * remove empty file * fix templating name * fixes * Switch etlReadOnlyMode false * Bump to v1.94.0-rc.0 Commit auto-generated by release script. * Updated to have the context name description next to clusterName. (#1450) * Update cluster-controller to v0.1.0 This includes a BREAKING CHANGE to the cluster-turndown functionality that is wrapped by cluster-controller. The breaking changes are summarized in https://github.com/kubecost/cluster-turndown/releases/tag/v2.0.0 and should be featured prominently in release notes. * Update turndownschedules CRD for v2 of turndown v2 of turndown changes the namespacing of the turndown resources to match K8s API policy. See discussion and references in kubecost/cluster-turndown#44 for more detail. The new CRD YAML is copied from cluster-turndown v2.0.1 * Fix infinite redirect for users with no rbac roles * Pick etl-filestore-default for v1.94 (#1453) * Add etlFileStoreEnabled: true to values.yaml * Update helm chart to default to ETL file store * Bump to v1.94.0-rc.1 (#1458) Commit auto-generated by release script. * Bump to v1.94.0 (#1463) Commit auto-generated by release script. Co-authored-by: keith.hand <keith@hand.technology> Co-authored-by: keith.hand <43491549+keithhand@users.noreply.github.com> Co-authored-by: keith.hand <rkeithhand@gmail.com> Co-authored-by: Kaelan Patel <kaelanspatel@gmail.com> Co-authored-by: Niko Kovacevic <nikovacevic@gmail.com> Co-authored-by: Naresh Agrawal <62406250+nareshagrawal@users.noreply.github.com> Co-authored-by: Cameron Hall <me@chall.id.au> Co-authored-by: Ajay Tripathy <ajay@kubecost.com> Co-authored-by: Volodymyr <vova3379@users.noreply.github.com> Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> Co-authored-by: Michael Dresser <michaelmdresser@gmail.com> Co-authored-by: dschunack <dschunack@web.de> Co-authored-by: Neal Ormsbee <neal.ormsbee@gmail.com> Co-authored-by: Daniel Ramich <dan@inngest.com> Co-authored-by: Dan Ramich <dramich@users.noreply.github.com> Co-authored-by: Sean Holcomb <seanholcomb@gmail.com> Co-authored-by: Matt Bolt <mbolt35@gmail.com> Co-authored-by: Kaelan Patel <32113845+kaelanspatel@users.noreply.github.com> Co-authored-by: Jesse Goodier <31039225+jessegoodier@users.noreply.github.com> Co-authored-by: Sean Pomeroy <sean.pomeroy@gmail.com> Co-authored-by: wolfeaustin <wolfe_austin@yahoo.com> Co-authored-by: Morten Mjelva <morten.mjelva@gmail.com> Co-authored-by: James Jarrett <jjarrett21@gmail.com> Co-authored-by: Brandon High <highb@users.noreply.github.com>
AjayTripathy
added a commit
to kubecost/cost-analyzer-helm-chart
that referenced
this pull request
Jun 9, 2022
* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <ajay@kubecost.com> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * White List LoadBalancer Cost * Add kubecost_load_balancer_cost to Metric White List * Add logging to readme * add detail to helm install notes (#1418) * add detail to helm install notes * Add error_throttle_sleep to Grafana sidecar (#1413) * Add editor group to RBAC * apiextensions.k8s.io/v1beta1 to v1 * conditional api use * Remove duplicate 'RELEASE_NAME' env var * versioning fix * James/add pln support (#1433) * adds PLN language support * should restore formatting * formatting again * saved without formatting * selfsigned cert flags (#734) * selfsigned cert stuff * fix name of configmap * add selfsigned certs for all thanos deps * Document grafana.sidecar.dashboards.enabled and add to agent example (#1432) * Document grafana.sidecar.dashboards.enabled option in cost-analyzer chart * Update values-agent.yaml * Ajay tripathy etl readonly perms (#1421) * remove server block and associated values * fix conflicts * AjayTripathy-vmware * use flag to generate rbac templates * undo accidental change * add newline * remove empty file * fix templating name * fixes * Switch etlReadOnlyMode false * Bump to v1.94.0-rc.0 Commit auto-generated by release script. * Updated to have the context name description next to clusterName. (#1450) * Update cluster-controller to v0.1.0 This includes a BREAKING CHANGE to the cluster-turndown functionality that is wrapped by cluster-controller. The breaking changes are summarized in https://github.com/kubecost/cluster-turndown/releases/tag/v2.0.0 and should be featured prominently in release notes. * Update turndownschedules CRD for v2 of turndown v2 of turndown changes the namespacing of the turndown resources to match K8s API policy. See discussion and references in kubecost/cluster-turndown#44 for more detail. The new CRD YAML is copied from cluster-turndown v2.0.1 * Fix infinite redirect for users with no rbac roles * Pick etl-filestore-default for v1.94 (#1453) * Add etlFileStoreEnabled: true to values.yaml * Update helm chart to default to ETL file store * Bump to v1.94.0-rc.1 (#1458) Commit auto-generated by release script. * Bump to v1.94.0 (#1463) Commit auto-generated by release script. * Bump to v1.94.1 (#1466) Commit auto-generated by release script. Co-authored-by: keith.hand <keith@hand.technology> Co-authored-by: keith.hand <43491549+keithhand@users.noreply.github.com> Co-authored-by: keith.hand <rkeithhand@gmail.com> Co-authored-by: Kaelan Patel <kaelanspatel@gmail.com> Co-authored-by: Niko Kovacevic <nikovacevic@gmail.com> Co-authored-by: Naresh Agrawal <62406250+nareshagrawal@users.noreply.github.com> Co-authored-by: Cameron Hall <me@chall.id.au> Co-authored-by: Ajay Tripathy <ajay@kubecost.com> Co-authored-by: Volodymyr <vova3379@users.noreply.github.com> Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> Co-authored-by: Michael Dresser <michaelmdresser@gmail.com> Co-authored-by: dschunack <dschunack@web.de> Co-authored-by: Neal Ormsbee <neal.ormsbee@gmail.com> Co-authored-by: Daniel Ramich <dan@inngest.com> Co-authored-by: Dan Ramich <dramich@users.noreply.github.com> Co-authored-by: Sean Holcomb <seanholcomb@gmail.com> Co-authored-by: Matt Bolt <mbolt35@gmail.com> Co-authored-by: Kaelan Patel <32113845+kaelanspatel@users.noreply.github.com> Co-authored-by: Jesse Goodier <31039225+jessegoodier@users.noreply.github.com> Co-authored-by: Sean Pomeroy <sean.pomeroy@gmail.com> Co-authored-by: wolfeaustin <wolfe_austin@yahoo.com> Co-authored-by: Morten Mjelva <morten.mjelva@gmail.com> Co-authored-by: James Jarrett <jjarrett21@gmail.com> Co-authored-by: Brandon High <highb@users.noreply.github.com>
AjayTripathy
added a commit
to kubecost/cost-analyzer-helm-chart
that referenced
this pull request
Jun 9, 2022
* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <ajay@kubecost.com> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * White List LoadBalancer Cost * Add kubecost_load_balancer_cost to Metric White List * Add logging to readme * add detail to helm install notes (#1418) * add detail to helm install notes * Add error_throttle_sleep to Grafana sidecar (#1413) * Add editor group to RBAC * apiextensions.k8s.io/v1beta1 to v1 * conditional api use * Remove duplicate 'RELEASE_NAME' env var * versioning fix * James/add pln support (#1433) * adds PLN language support * should restore formatting * formatting again * saved without formatting * selfsigned cert flags (#734) * selfsigned cert stuff * fix name of configmap * add selfsigned certs for all thanos deps * Document grafana.sidecar.dashboards.enabled and add to agent example (#1432) * Document grafana.sidecar.dashboards.enabled option in cost-analyzer chart * Update values-agent.yaml * Ajay tripathy etl readonly perms (#1421) * remove server block and associated values * fix conflicts * AjayTripathy-vmware * use flag to generate rbac templates * undo accidental change * add newline * remove empty file * fix templating name * fixes * Switch etlReadOnlyMode false * Bump to v1.94.0-rc.0 Commit auto-generated by release script. * Updated to have the context name description next to clusterName. (#1450) * Update cluster-controller to v0.1.0 This includes a BREAKING CHANGE to the cluster-turndown functionality that is wrapped by cluster-controller. The breaking changes are summarized in https://github.com/kubecost/cluster-turndown/releases/tag/v2.0.0 and should be featured prominently in release notes. * Update turndownschedules CRD for v2 of turndown v2 of turndown changes the namespacing of the turndown resources to match K8s API policy. See discussion and references in kubecost/cluster-turndown#44 for more detail. The new CRD YAML is copied from cluster-turndown v2.0.1 * Fix infinite redirect for users with no rbac roles * Pick etl-filestore-default for v1.94 (#1453) * Add etlFileStoreEnabled: true to values.yaml * Update helm chart to default to ETL file store * Bump to v1.94.0-rc.1 (#1458) Commit auto-generated by release script. * Bump to v1.94.0 (#1463) Commit auto-generated by release script. * Bump to v1.94.1 (#1466) Commit auto-generated by release script. * Bump to v1.94.2 (#1469) Commit auto-generated by release script. Co-authored-by: keith.hand <keith@hand.technology> Co-authored-by: keith.hand <43491549+keithhand@users.noreply.github.com> Co-authored-by: keith.hand <rkeithhand@gmail.com> Co-authored-by: Kaelan Patel <kaelanspatel@gmail.com> Co-authored-by: Niko Kovacevic <nikovacevic@gmail.com> Co-authored-by: Naresh Agrawal <62406250+nareshagrawal@users.noreply.github.com> Co-authored-by: Cameron Hall <me@chall.id.au> Co-authored-by: Ajay Tripathy <ajay@kubecost.com> Co-authored-by: Volodymyr <vova3379@users.noreply.github.com> Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> Co-authored-by: Michael Dresser <michaelmdresser@gmail.com> Co-authored-by: dschunack <dschunack@web.de> Co-authored-by: Neal Ormsbee <neal.ormsbee@gmail.com> Co-authored-by: Daniel Ramich <dan@inngest.com> Co-authored-by: Dan Ramich <dramich@users.noreply.github.com> Co-authored-by: Sean Holcomb <seanholcomb@gmail.com> Co-authored-by: Matt Bolt <mbolt35@gmail.com> Co-authored-by: Kaelan Patel <32113845+kaelanspatel@users.noreply.github.com> Co-authored-by: Jesse Goodier <31039225+jessegoodier@users.noreply.github.com> Co-authored-by: Sean Pomeroy <sean.pomeroy@gmail.com> Co-authored-by: wolfeaustin <wolfe_austin@yahoo.com> Co-authored-by: Morten Mjelva <morten.mjelva@gmail.com> Co-authored-by: James Jarrett <jjarrett21@gmail.com> Co-authored-by: Brandon High <highb@users.noreply.github.com>
AjayTripathy
added a commit
to kubecost/cost-analyzer-helm-chart
that referenced
this pull request
Jun 13, 2022
* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <ajay@kubecost.com> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * White List LoadBalancer Cost * Add kubecost_load_balancer_cost to Metric White List * Add logging to readme * add detail to helm install notes (#1418) * add detail to helm install notes * Add error_throttle_sleep to Grafana sidecar (#1413) * Add editor group to RBAC * apiextensions.k8s.io/v1beta1 to v1 * conditional api use * Remove duplicate 'RELEASE_NAME' env var * versioning fix * James/add pln support (#1433) * adds PLN language support * should restore formatting * formatting again * saved without formatting * selfsigned cert flags (#734) * selfsigned cert stuff * fix name of configmap * add selfsigned certs for all thanos deps * Document grafana.sidecar.dashboards.enabled and add to agent example (#1432) * Document grafana.sidecar.dashboards.enabled option in cost-analyzer chart * Update values-agent.yaml * Ajay tripathy etl readonly perms (#1421) * remove server block and associated values * fix conflicts * AjayTripathy-vmware * use flag to generate rbac templates * undo accidental change * add newline * remove empty file * fix templating name * fixes * Switch etlReadOnlyMode false * Bump to v1.94.0-rc.0 Commit auto-generated by release script. * Updated to have the context name description next to clusterName. (#1450) * Update cluster-controller to v0.1.0 This includes a BREAKING CHANGE to the cluster-turndown functionality that is wrapped by cluster-controller. The breaking changes are summarized in https://github.com/kubecost/cluster-turndown/releases/tag/v2.0.0 and should be featured prominently in release notes. * Update turndownschedules CRD for v2 of turndown v2 of turndown changes the namespacing of the turndown resources to match K8s API policy. See discussion and references in kubecost/cluster-turndown#44 for more detail. The new CRD YAML is copied from cluster-turndown v2.0.1 * Fix infinite redirect for users with no rbac roles * Pick etl-filestore-default for v1.94 (#1453) * Add etlFileStoreEnabled: true to values.yaml * Update helm chart to default to ETL file store * Bump to v1.94.0-rc.1 (#1458) Commit auto-generated by release script. * Bump to v1.94.0 (#1463) Commit auto-generated by release script. * Bump to v1.94.1 (#1466) Commit auto-generated by release script. * Bump to v1.94.2 (#1469) Commit auto-generated by release script. * Bump to v1.94.3 (#1479) Commit auto-generated by release script. Co-authored-by: keith.hand <keith@hand.technology> Co-authored-by: keith.hand <43491549+keithhand@users.noreply.github.com> Co-authored-by: keith.hand <rkeithhand@gmail.com> Co-authored-by: Kaelan Patel <kaelanspatel@gmail.com> Co-authored-by: Niko Kovacevic <nikovacevic@gmail.com> Co-authored-by: Naresh Agrawal <62406250+nareshagrawal@users.noreply.github.com> Co-authored-by: Cameron Hall <me@chall.id.au> Co-authored-by: Ajay Tripathy <ajay@kubecost.com> Co-authored-by: Volodymyr <vova3379@users.noreply.github.com> Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> Co-authored-by: Michael Dresser <michaelmdresser@gmail.com> Co-authored-by: dschunack <dschunack@web.de> Co-authored-by: Neal Ormsbee <neal.ormsbee@gmail.com> Co-authored-by: Daniel Ramich <dan@inngest.com> Co-authored-by: Dan Ramich <dramich@users.noreply.github.com> Co-authored-by: Sean Holcomb <seanholcomb@gmail.com> Co-authored-by: Matt Bolt <mbolt35@gmail.com> Co-authored-by: Kaelan Patel <32113845+kaelanspatel@users.noreply.github.com> Co-authored-by: Jesse Goodier <31039225+jessegoodier@users.noreply.github.com> Co-authored-by: Sean Pomeroy <sean.pomeroy@gmail.com> Co-authored-by: wolfeaustin <wolfe_austin@yahoo.com> Co-authored-by: Morten Mjelva <morten.mjelva@gmail.com> Co-authored-by: James Jarrett <jjarrett21@gmail.com> Co-authored-by: Brandon High <highb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #40.
Changes
apiextensions.k8s.io/v1beta1is removed as of K8s v1.22 [1], so all CRDshave to be updated to
apiextensions.k8s.io/v1. This commit does theupgrade for the
turndownscheduleCRD.As part of the API updates, K8s is enforcing things grouped under
*.k8s.ioto be approved [2] because they are actually supposed to beKubernetes community-managed APIs [3]. So this commit also changes the
CRD from:
turndownschedules.kubecost.k8s.ioto
turndownschedules.kubecost.comThis is in-line with K8s rules and links to our main domain.
Testing
Tested by applying
cluster-turndown-full.yamlandexample-schedule.yamlsuccessfully (with updated container image from this commit) as instructed
by the README.
Notes
We did a similar change in kubecost/cost-analyzer-helm-chart#1429 but didn't do all of the necessary steps, like changing the CRD group to
kubecost.comand similar changes. Once this PR has been approved, merged, and a new version of cluster-turndown is released, we'll have to update cluster-controller (because of the regenerated code forturndownschedules.kubecost.com) and the turndownschedule CRD in the main Kubecost Helm chart.[1] https://cloud.google.com/kubernetes-engine/docs/deprecations/apis-1-22
[2] kubernetes/enhancements#1111
[3] kubernetes/enhancements#1111 (comment)