Ajay tripathy etl readonly perms #1421

AjayTripathy · 2022-05-12T02:13:56Z

What does this PR change?

Flag support for running ETL in a low-permission mode where it simply connects to a PromQL database assumed to have cost data and its own configmaps.

Does this PR rely on any other PRs?

The supporting PRs are already merged

How does this PR impact users? (This is the kind of thing that goes in release notes!)

Users will be able to run kubecost without permissions outside of its own namespace, assuming agents in other namespaces have those permissions.

Links to Issues or ZD tickets this PR addresses or fixes

How was this PR tested?

Run with the new flag disabled, and ensure the right metrics are generated
Run with the new flag enabled, ensure kubecost runs and generates metric data

Have you made an update to documentation?

The flag should really be used sparingly; not suitable for almost every user.

…elm-chart into develop

…elm-chart into AjayTripathy-etl-readonly-perms

mbolt35 · 2022-05-12T13:57:49Z

cost-analyzer/templates/cost-analyzer-deployment-template.yaml

@@ -524,6 +524,10 @@ spec:
              value: {{ (quote .Values.kubecostModel.warmSavingsCache) | default (quote true) }}
            - name: ETL_ENABLED
              value: {{ (quote .Values.kubecostModel.etl) | default (quote true) }}
+            {{- if .Values.kubecostModel.etlReadOnlyMode }}


The only thing I think is still a bit confusing here: Is this really setting ETL to read-only? Does reconciliation not make adjustments and update the ETL?

Ah, it does. I think that's a fair point that this is a misnomer since reconciliation will still ocur. Any naming suggestions?

I agree this is a tough one to name. I guess we should've renamed at the cost-model level first since the env var has the same name... I suppose it's better to keep the consistency.

mbolt35 · 2022-05-12T22:17:01Z

cost-analyzer/values.yaml

@@ -268,6 +268,8 @@ kubecostModel:
  # The total number of hours the ETL pipelines will build
  # Set to 0 to disable hourly ETL (not recommended)
  etlHourlyStoreDurationHours: 49
+  # For deploying kubecost in a cluster that does not self-monitor
+  etlReadOnlyMode: true


We don't want to default this to true, right?

Good catch, holdover from testing...

Adam-Stack-PM · 2022-05-22T22:46:56Z

@AjayTripathy, Can we get this updated and merged early this week?

AjayTripathy · 2022-05-25T17:35:47Z

Yeah, let me ping for another review.

mbolt35

Looks good!

Adam-Stack-PM · 2022-05-26T13:37:30Z

@AjayTripathy Is anything blocking merging this today?

* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <ajay@kubecost.com> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * White List LoadBalancer Cost * Add kubecost_load_balancer_cost to Metric White List * Add logging to readme * add detail to helm install notes (#1418) * add detail to helm install notes * Add error_throttle_sleep to Grafana sidecar (#1413) * Add editor group to RBAC * apiextensions.k8s.io/v1beta1 to v1 * conditional api use * Remove duplicate 'RELEASE_NAME' env var * versioning fix * James/add pln support (#1433) * adds PLN language support * should restore formatting * formatting again * saved without formatting * selfsigned cert flags (#734) * selfsigned cert stuff * fix name of configmap * add selfsigned certs for all thanos deps * Document grafana.sidecar.dashboards.enabled and add to agent example (#1432) * Document grafana.sidecar.dashboards.enabled option in cost-analyzer chart * Update values-agent.yaml * Ajay tripathy etl readonly perms (#1421) * remove server block and associated values * fix conflicts * AjayTripathy-vmware * use flag to generate rbac templates * undo accidental change * add newline * remove empty file * fix templating name * fixes * Switch etlReadOnlyMode false * Bump to v1.94.0-rc.0 Commit auto-generated by release script. Co-authored-by: keith.hand <keith@hand.technology> Co-authored-by: keith.hand <43491549+keithhand@users.noreply.github.com> Co-authored-by: keith.hand <rkeithhand@gmail.com> Co-authored-by: Kaelan Patel <kaelanspatel@gmail.com> Co-authored-by: Niko Kovacevic <nikovacevic@gmail.com> Co-authored-by: Naresh Agrawal <62406250+nareshagrawal@users.noreply.github.com> Co-authored-by: Cameron Hall <me@chall.id.au> Co-authored-by: Ajay Tripathy <ajay@kubecost.com> Co-authored-by: Volodymyr <vova3379@users.noreply.github.com> Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> Co-authored-by: Michael Dresser <michaelmdresser@gmail.com> Co-authored-by: dschunack <dschunack@web.de> Co-authored-by: Neal Ormsbee <neal.ormsbee@gmail.com> Co-authored-by: Daniel Ramich <dan@inngest.com> Co-authored-by: Dan Ramich <dramich@users.noreply.github.com> Co-authored-by: Sean Holcomb <seanholcomb@gmail.com> Co-authored-by: Matt Bolt <mbolt35@gmail.com> Co-authored-by: Kaelan Patel <32113845+kaelanspatel@users.noreply.github.com> Co-authored-by: Jesse Goodier <31039225+jessegoodier@users.noreply.github.com> Co-authored-by: Sean Pomeroy <sean.pomeroy@gmail.com> Co-authored-by: wolfeaustin <wolfe_austin@yahoo.com> Co-authored-by: Morten Mjelva <morten.mjelva@gmail.com> Co-authored-by: James Jarrett <jjarrett21@gmail.com> Co-authored-by: Brandon High <highb@users.noreply.github.com>

* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <ajay@kubecost.com> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * White List LoadBalancer Cost * Add kubecost_load_balancer_cost to Metric White List * Add logging to readme * add detail to helm install notes (#1418) * add detail to helm install notes * Add error_throttle_sleep to Grafana sidecar (#1413) * Add editor group to RBAC * apiextensions.k8s.io/v1beta1 to v1 * conditional api use * Remove duplicate 'RELEASE_NAME' env var * versioning fix * James/add pln support (#1433) * adds PLN language support * should restore formatting * formatting again * saved without formatting * selfsigned cert flags (#734) * selfsigned cert stuff * fix name of configmap * add selfsigned certs for all thanos deps * Document grafana.sidecar.dashboards.enabled and add to agent example (#1432) * Document grafana.sidecar.dashboards.enabled option in cost-analyzer chart * Update values-agent.yaml * Ajay tripathy etl readonly perms (#1421) * remove server block and associated values * fix conflicts * AjayTripathy-vmware * use flag to generate rbac templates * undo accidental change * add newline * remove empty file * fix templating name * fixes * Switch etlReadOnlyMode false * Bump to v1.94.0-rc.0 Commit auto-generated by release script. * Updated to have the context name description next to clusterName. (#1450) * Update cluster-controller to v0.1.0 This includes a BREAKING CHANGE to the cluster-turndown functionality that is wrapped by cluster-controller. The breaking changes are summarized in https://github.com/kubecost/cluster-turndown/releases/tag/v2.0.0 and should be featured prominently in release notes. * Update turndownschedules CRD for v2 of turndown v2 of turndown changes the namespacing of the turndown resources to match K8s API policy. See discussion and references in kubecost/cluster-turndown#44 for more detail. The new CRD YAML is copied from cluster-turndown v2.0.1 * Fix infinite redirect for users with no rbac roles * Pick etl-filestore-default for v1.94 (#1453) * Add etlFileStoreEnabled: true to values.yaml * Update helm chart to default to ETL file store * Bump to v1.94.0-rc.1 (#1458) Commit auto-generated by release script. Co-authored-by: keith.hand <keith@hand.technology> Co-authored-by: keith.hand <43491549+keithhand@users.noreply.github.com> Co-authored-by: keith.hand <rkeithhand@gmail.com> Co-authored-by: Kaelan Patel <kaelanspatel@gmail.com> Co-authored-by: Niko Kovacevic <nikovacevic@gmail.com> Co-authored-by: Naresh Agrawal <62406250+nareshagrawal@users.noreply.github.com> Co-authored-by: Cameron Hall <me@chall.id.au> Co-authored-by: Ajay Tripathy <ajay@kubecost.com> Co-authored-by: Volodymyr <vova3379@users.noreply.github.com> Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> Co-authored-by: Michael Dresser <michaelmdresser@gmail.com> Co-authored-by: dschunack <dschunack@web.de> Co-authored-by: Neal Ormsbee <neal.ormsbee@gmail.com> Co-authored-by: Daniel Ramich <dan@inngest.com> Co-authored-by: Dan Ramich <dramich@users.noreply.github.com> Co-authored-by: Sean Holcomb <seanholcomb@gmail.com> Co-authored-by: Matt Bolt <mbolt35@gmail.com> Co-authored-by: Kaelan Patel <32113845+kaelanspatel@users.noreply.github.com> Co-authored-by: Jesse Goodier <31039225+jessegoodier@users.noreply.github.com> Co-authored-by: Sean Pomeroy <sean.pomeroy@gmail.com> Co-authored-by: wolfeaustin <wolfe_austin@yahoo.com> Co-authored-by: Morten Mjelva <morten.mjelva@gmail.com> Co-authored-by: James Jarrett <jjarrett21@gmail.com> Co-authored-by: Brandon High <highb@users.noreply.github.com>

* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <ajay@kubecost.com> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * White List LoadBalancer Cost * Add kubecost_load_balancer_cost to Metric White List * Add logging to readme * add detail to helm install notes (#1418) * add detail to helm install notes * Add error_throttle_sleep to Grafana sidecar (#1413) * Add editor group to RBAC * apiextensions.k8s.io/v1beta1 to v1 * conditional api use * Remove duplicate 'RELEASE_NAME' env var * versioning fix * James/add pln support (#1433) * adds PLN language support * should restore formatting * formatting again * saved without formatting * selfsigned cert flags (#734) * selfsigned cert stuff * fix name of configmap * add selfsigned certs for all thanos deps * Document grafana.sidecar.dashboards.enabled and add to agent example (#1432) * Document grafana.sidecar.dashboards.enabled option in cost-analyzer chart * Update values-agent.yaml * Ajay tripathy etl readonly perms (#1421) * remove server block and associated values * fix conflicts * AjayTripathy-vmware * use flag to generate rbac templates * undo accidental change * add newline * remove empty file * fix templating name * fixes * Switch etlReadOnlyMode false * Bump to v1.94.0-rc.0 Commit auto-generated by release script. * Updated to have the context name description next to clusterName. (#1450) * Update cluster-controller to v0.1.0 This includes a BREAKING CHANGE to the cluster-turndown functionality that is wrapped by cluster-controller. The breaking changes are summarized in https://github.com/kubecost/cluster-turndown/releases/tag/v2.0.0 and should be featured prominently in release notes. * Update turndownschedules CRD for v2 of turndown v2 of turndown changes the namespacing of the turndown resources to match K8s API policy. See discussion and references in kubecost/cluster-turndown#44 for more detail. The new CRD YAML is copied from cluster-turndown v2.0.1 * Fix infinite redirect for users with no rbac roles * Pick etl-filestore-default for v1.94 (#1453) * Add etlFileStoreEnabled: true to values.yaml * Update helm chart to default to ETL file store * Bump to v1.94.0-rc.1 (#1458) Commit auto-generated by release script. * Bump to v1.94.0 (#1463) Commit auto-generated by release script. Co-authored-by: keith.hand <keith@hand.technology> Co-authored-by: keith.hand <43491549+keithhand@users.noreply.github.com> Co-authored-by: keith.hand <rkeithhand@gmail.com> Co-authored-by: Kaelan Patel <kaelanspatel@gmail.com> Co-authored-by: Niko Kovacevic <nikovacevic@gmail.com> Co-authored-by: Naresh Agrawal <62406250+nareshagrawal@users.noreply.github.com> Co-authored-by: Cameron Hall <me@chall.id.au> Co-authored-by: Ajay Tripathy <ajay@kubecost.com> Co-authored-by: Volodymyr <vova3379@users.noreply.github.com> Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> Co-authored-by: Michael Dresser <michaelmdresser@gmail.com> Co-authored-by: dschunack <dschunack@web.de> Co-authored-by: Neal Ormsbee <neal.ormsbee@gmail.com> Co-authored-by: Daniel Ramich <dan@inngest.com> Co-authored-by: Dan Ramich <dramich@users.noreply.github.com> Co-authored-by: Sean Holcomb <seanholcomb@gmail.com> Co-authored-by: Matt Bolt <mbolt35@gmail.com> Co-authored-by: Kaelan Patel <32113845+kaelanspatel@users.noreply.github.com> Co-authored-by: Jesse Goodier <31039225+jessegoodier@users.noreply.github.com> Co-authored-by: Sean Pomeroy <sean.pomeroy@gmail.com> Co-authored-by: wolfeaustin <wolfe_austin@yahoo.com> Co-authored-by: Morten Mjelva <morten.mjelva@gmail.com> Co-authored-by: James Jarrett <jjarrett21@gmail.com> Co-authored-by: Brandon High <highb@users.noreply.github.com>

* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <ajay@kubecost.com> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * White List LoadBalancer Cost * Add kubecost_load_balancer_cost to Metric White List * Add logging to readme * add detail to helm install notes (#1418) * add detail to helm install notes * Add error_throttle_sleep to Grafana sidecar (#1413) * Add editor group to RBAC * apiextensions.k8s.io/v1beta1 to v1 * conditional api use * Remove duplicate 'RELEASE_NAME' env var * versioning fix * James/add pln support (#1433) * adds PLN language support * should restore formatting * formatting again * saved without formatting * selfsigned cert flags (#734) * selfsigned cert stuff * fix name of configmap * add selfsigned certs for all thanos deps * Document grafana.sidecar.dashboards.enabled and add to agent example (#1432) * Document grafana.sidecar.dashboards.enabled option in cost-analyzer chart * Update values-agent.yaml * Ajay tripathy etl readonly perms (#1421) * remove server block and associated values * fix conflicts * AjayTripathy-vmware * use flag to generate rbac templates * undo accidental change * add newline * remove empty file * fix templating name * fixes * Switch etlReadOnlyMode false * Bump to v1.94.0-rc.0 Commit auto-generated by release script. * Updated to have the context name description next to clusterName. (#1450) * Update cluster-controller to v0.1.0 This includes a BREAKING CHANGE to the cluster-turndown functionality that is wrapped by cluster-controller. The breaking changes are summarized in https://github.com/kubecost/cluster-turndown/releases/tag/v2.0.0 and should be featured prominently in release notes. * Update turndownschedules CRD for v2 of turndown v2 of turndown changes the namespacing of the turndown resources to match K8s API policy. See discussion and references in kubecost/cluster-turndown#44 for more detail. The new CRD YAML is copied from cluster-turndown v2.0.1 * Fix infinite redirect for users with no rbac roles * Pick etl-filestore-default for v1.94 (#1453) * Add etlFileStoreEnabled: true to values.yaml * Update helm chart to default to ETL file store * Bump to v1.94.0-rc.1 (#1458) Commit auto-generated by release script. * Bump to v1.94.0 (#1463) Commit auto-generated by release script. * Bump to v1.94.1 (#1466) Commit auto-generated by release script. Co-authored-by: keith.hand <keith@hand.technology> Co-authored-by: keith.hand <43491549+keithhand@users.noreply.github.com> Co-authored-by: keith.hand <rkeithhand@gmail.com> Co-authored-by: Kaelan Patel <kaelanspatel@gmail.com> Co-authored-by: Niko Kovacevic <nikovacevic@gmail.com> Co-authored-by: Naresh Agrawal <62406250+nareshagrawal@users.noreply.github.com> Co-authored-by: Cameron Hall <me@chall.id.au> Co-authored-by: Ajay Tripathy <ajay@kubecost.com> Co-authored-by: Volodymyr <vova3379@users.noreply.github.com> Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> Co-authored-by: Michael Dresser <michaelmdresser@gmail.com> Co-authored-by: dschunack <dschunack@web.de> Co-authored-by: Neal Ormsbee <neal.ormsbee@gmail.com> Co-authored-by: Daniel Ramich <dan@inngest.com> Co-authored-by: Dan Ramich <dramich@users.noreply.github.com> Co-authored-by: Sean Holcomb <seanholcomb@gmail.com> Co-authored-by: Matt Bolt <mbolt35@gmail.com> Co-authored-by: Kaelan Patel <32113845+kaelanspatel@users.noreply.github.com> Co-authored-by: Jesse Goodier <31039225+jessegoodier@users.noreply.github.com> Co-authored-by: Sean Pomeroy <sean.pomeroy@gmail.com> Co-authored-by: wolfeaustin <wolfe_austin@yahoo.com> Co-authored-by: Morten Mjelva <morten.mjelva@gmail.com> Co-authored-by: James Jarrett <jjarrett21@gmail.com> Co-authored-by: Brandon High <highb@users.noreply.github.com>

* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <ajay@kubecost.com> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * White List LoadBalancer Cost * Add kubecost_load_balancer_cost to Metric White List * Add logging to readme * add detail to helm install notes (#1418) * add detail to helm install notes * Add error_throttle_sleep to Grafana sidecar (#1413) * Add editor group to RBAC * apiextensions.k8s.io/v1beta1 to v1 * conditional api use * Remove duplicate 'RELEASE_NAME' env var * versioning fix * James/add pln support (#1433) * adds PLN language support * should restore formatting * formatting again * saved without formatting * selfsigned cert flags (#734) * selfsigned cert stuff * fix name of configmap * add selfsigned certs for all thanos deps * Document grafana.sidecar.dashboards.enabled and add to agent example (#1432) * Document grafana.sidecar.dashboards.enabled option in cost-analyzer chart * Update values-agent.yaml * Ajay tripathy etl readonly perms (#1421) * remove server block and associated values * fix conflicts * AjayTripathy-vmware * use flag to generate rbac templates * undo accidental change * add newline * remove empty file * fix templating name * fixes * Switch etlReadOnlyMode false * Bump to v1.94.0-rc.0 Commit auto-generated by release script. * Updated to have the context name description next to clusterName. (#1450) * Update cluster-controller to v0.1.0 This includes a BREAKING CHANGE to the cluster-turndown functionality that is wrapped by cluster-controller. The breaking changes are summarized in https://github.com/kubecost/cluster-turndown/releases/tag/v2.0.0 and should be featured prominently in release notes. * Update turndownschedules CRD for v2 of turndown v2 of turndown changes the namespacing of the turndown resources to match K8s API policy. See discussion and references in kubecost/cluster-turndown#44 for more detail. The new CRD YAML is copied from cluster-turndown v2.0.1 * Fix infinite redirect for users with no rbac roles * Pick etl-filestore-default for v1.94 (#1453) * Add etlFileStoreEnabled: true to values.yaml * Update helm chart to default to ETL file store * Bump to v1.94.0-rc.1 (#1458) Commit auto-generated by release script. * Bump to v1.94.0 (#1463) Commit auto-generated by release script. * Bump to v1.94.1 (#1466) Commit auto-generated by release script. * Bump to v1.94.2 (#1469) Commit auto-generated by release script. Co-authored-by: keith.hand <keith@hand.technology> Co-authored-by: keith.hand <43491549+keithhand@users.noreply.github.com> Co-authored-by: keith.hand <rkeithhand@gmail.com> Co-authored-by: Kaelan Patel <kaelanspatel@gmail.com> Co-authored-by: Niko Kovacevic <nikovacevic@gmail.com> Co-authored-by: Naresh Agrawal <62406250+nareshagrawal@users.noreply.github.com> Co-authored-by: Cameron Hall <me@chall.id.au> Co-authored-by: Ajay Tripathy <ajay@kubecost.com> Co-authored-by: Volodymyr <vova3379@users.noreply.github.com> Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> Co-authored-by: Michael Dresser <michaelmdresser@gmail.com> Co-authored-by: dschunack <dschunack@web.de> Co-authored-by: Neal Ormsbee <neal.ormsbee@gmail.com> Co-authored-by: Daniel Ramich <dan@inngest.com> Co-authored-by: Dan Ramich <dramich@users.noreply.github.com> Co-authored-by: Sean Holcomb <seanholcomb@gmail.com> Co-authored-by: Matt Bolt <mbolt35@gmail.com> Co-authored-by: Kaelan Patel <32113845+kaelanspatel@users.noreply.github.com> Co-authored-by: Jesse Goodier <31039225+jessegoodier@users.noreply.github.com> Co-authored-by: Sean Pomeroy <sean.pomeroy@gmail.com> Co-authored-by: wolfeaustin <wolfe_austin@yahoo.com> Co-authored-by: Morten Mjelva <morten.mjelva@gmail.com> Co-authored-by: James Jarrett <jjarrett21@gmail.com> Co-authored-by: Brandon High <highb@users.noreply.github.com>

* Pin local chart dependencies in Chart.yaml files * Add condition flags for dependencies * Add condition flag for kube-state-metrics chart * Add INGEST_POD_UID env variable + helm value * Re-comment code + add clarification * remove deprecated server port * Add maxPrometheusQueryDurationMinutes setting * Update values.yaml (#1342) * Added SEK to supported currencies. * Added in Customer Google Tag to values and environment variables * Fixed tag names. * Updated google analytics tag to be marked as enterprise. * Fix duplicate app labels and expose Grafana PSP config (#1347) * fix: fixed duplicate app labels in metric exporter * fix: added default value for Grafana PSP Co-authored-by: Ajay Tripathy <ajay@kubecost.com> * FIX prometheus ingress (#1375) Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> * cluster controller service key secret optional This smooths the adoption path for cluster controller features, like 1-click request sizing, that don't require service keys. Cluster controller will be updated to gracefully handle situations where these keys don't exist. * Reverse patch of #1361 into develop from v1.92 * Reverse patch of #1338 into develop from v1.92 * cluster controller to v0.0.6 for optional secret * Changing version (#1381) Changing to lastest version i.e. 1.92.0 * Fix PSP issue for Network-Costs if you want to run multiple kubecost maybe for Testing Use Release Name instead of ServiceAccount Name for Role, ClusterRole and bindings. * Adds an env var to the cost model indicating whether Grafana is enabled. * Modified GRAFANA_ENABLED env var logic to be clearer * Add athena workgroup to config * fix cloud usage defaulting * Remove GOGC tuning from cost-model * Add github action to validate chart * White List LoadBalancer Cost * Add kubecost_load_balancer_cost to Metric White List * Add logging to readme * add detail to helm install notes (#1418) * add detail to helm install notes * Add error_throttle_sleep to Grafana sidecar (#1413) * Add editor group to RBAC * apiextensions.k8s.io/v1beta1 to v1 * conditional api use * Remove duplicate 'RELEASE_NAME' env var * versioning fix * James/add pln support (#1433) * adds PLN language support * should restore formatting * formatting again * saved without formatting * selfsigned cert flags (#734) * selfsigned cert stuff * fix name of configmap * add selfsigned certs for all thanos deps * Document grafana.sidecar.dashboards.enabled and add to agent example (#1432) * Document grafana.sidecar.dashboards.enabled option in cost-analyzer chart * Update values-agent.yaml * Ajay tripathy etl readonly perms (#1421) * remove server block and associated values * fix conflicts * AjayTripathy-vmware * use flag to generate rbac templates * undo accidental change * add newline * remove empty file * fix templating name * fixes * Switch etlReadOnlyMode false * Bump to v1.94.0-rc.0 Commit auto-generated by release script. * Updated to have the context name description next to clusterName. (#1450) * Update cluster-controller to v0.1.0 This includes a BREAKING CHANGE to the cluster-turndown functionality that is wrapped by cluster-controller. The breaking changes are summarized in https://github.com/kubecost/cluster-turndown/releases/tag/v2.0.0 and should be featured prominently in release notes. * Update turndownschedules CRD for v2 of turndown v2 of turndown changes the namespacing of the turndown resources to match K8s API policy. See discussion and references in kubecost/cluster-turndown#44 for more detail. The new CRD YAML is copied from cluster-turndown v2.0.1 * Fix infinite redirect for users with no rbac roles * Pick etl-filestore-default for v1.94 (#1453) * Add etlFileStoreEnabled: true to values.yaml * Update helm chart to default to ETL file store * Bump to v1.94.0-rc.1 (#1458) Commit auto-generated by release script. * Bump to v1.94.0 (#1463) Commit auto-generated by release script. * Bump to v1.94.1 (#1466) Commit auto-generated by release script. * Bump to v1.94.2 (#1469) Commit auto-generated by release script. * Bump to v1.94.3 (#1479) Commit auto-generated by release script. Co-authored-by: keith.hand <keith@hand.technology> Co-authored-by: keith.hand <43491549+keithhand@users.noreply.github.com> Co-authored-by: keith.hand <rkeithhand@gmail.com> Co-authored-by: Kaelan Patel <kaelanspatel@gmail.com> Co-authored-by: Niko Kovacevic <nikovacevic@gmail.com> Co-authored-by: Naresh Agrawal <62406250+nareshagrawal@users.noreply.github.com> Co-authored-by: Cameron Hall <me@chall.id.au> Co-authored-by: Ajay Tripathy <ajay@kubecost.com> Co-authored-by: Volodymyr <vova3379@users.noreply.github.com> Co-authored-by: Volodymyr Lisnyi <volodymyrlisnyi@MacBook-Pro-Volodymyr.local> Co-authored-by: Michael Dresser <michaelmdresser@gmail.com> Co-authored-by: dschunack <dschunack@web.de> Co-authored-by: Neal Ormsbee <neal.ormsbee@gmail.com> Co-authored-by: Daniel Ramich <dan@inngest.com> Co-authored-by: Dan Ramich <dramich@users.noreply.github.com> Co-authored-by: Sean Holcomb <seanholcomb@gmail.com> Co-authored-by: Matt Bolt <mbolt35@gmail.com> Co-authored-by: Kaelan Patel <32113845+kaelanspatel@users.noreply.github.com> Co-authored-by: Jesse Goodier <31039225+jessegoodier@users.noreply.github.com> Co-authored-by: Sean Pomeroy <sean.pomeroy@gmail.com> Co-authored-by: wolfeaustin <wolfe_austin@yahoo.com> Co-authored-by: Morten Mjelva <morten.mjelva@gmail.com> Co-authored-by: James Jarrett <jjarrett21@gmail.com> Co-authored-by: Brandon High <highb@users.noreply.github.com>

AjayTripathy added 13 commits March 27, 2022 12:38

remove server block and associated values

93be848

Merge branch 'develop' of https://github.com/kubecost/cost-analyzer-h…

70dda7b

…elm-chart into develop

Merge branch 'develop' of https://github.com/kubecost/cost-analyzer-h…

4b6a2f7

…elm-chart into develop

Merge branch 'develop' of https://github.com/kubecost/cost-analyzer-h…

b7fdff7

…elm-chart into develop

fix conflicts

7bcc946

AjayTripathy-vmware

fa0189a

Merge branch 'develop' of https://github.com/kubecost/cost-analyzer-h…

d463519

…elm-chart into AjayTripathy-etl-readonly-perms

use flag to generate rbac templates

1f2422d

undo accidental change

ca0b252

add newline

0c555e5

remove empty file

0150d78

fix templating name

586766e

fixes

6131391

mbolt35 reviewed May 12, 2022

View reviewed changes

AjayTripathy changed the title ~~Ajay tripathy etl readonly perms [DRAFT]~~ Ajay tripathy etl readonly perms May 12, 2022

AjayTripathy added the v1.94 label May 12, 2022

mbolt35 reviewed May 12, 2022

View reviewed changes

Switch etlReadOnlyMode false

8711227

Adam-Stack-PM assigned AjayTripathy May 18, 2022

AjayTripathy mentioned this pull request May 25, 2022

Experimental namespace rbac #1076

Closed

mbolt35 approved these changes May 25, 2022

View reviewed changes

AjayTripathy merged commit 40864a4 into develop May 26, 2022

chipzoller deleted the AjayTripathy-etl-readonly-perms branch October 4, 2023 22:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ajay tripathy etl readonly perms #1421

Ajay tripathy etl readonly perms #1421

AjayTripathy commented May 12, 2022 •

edited

Loading

mbolt35 May 12, 2022

AjayTripathy May 12, 2022

mbolt35 May 12, 2022

mbolt35 May 12, 2022

AjayTripathy May 13, 2022

Adam-Stack-PM commented May 22, 2022

AjayTripathy commented May 25, 2022

mbolt35 left a comment

Adam-Stack-PM commented May 26, 2022

Ajay tripathy etl readonly perms #1421

Ajay tripathy etl readonly perms #1421

Conversation

AjayTripathy commented May 12, 2022 • edited Loading

What does this PR change?

Does this PR rely on any other PRs?

How does this PR impact users? (This is the kind of thing that goes in release notes!)

Links to Issues or ZD tickets this PR addresses or fixes

How was this PR tested?

Have you made an update to documentation?

mbolt35 May 12, 2022

Choose a reason for hiding this comment

AjayTripathy May 12, 2022

Choose a reason for hiding this comment

mbolt35 May 12, 2022

Choose a reason for hiding this comment

mbolt35 May 12, 2022

Choose a reason for hiding this comment

AjayTripathy May 13, 2022

Choose a reason for hiding this comment

Adam-Stack-PM commented May 22, 2022

AjayTripathy commented May 25, 2022

mbolt35 left a comment

Choose a reason for hiding this comment

Adam-Stack-PM commented May 26, 2022

AjayTripathy commented May 12, 2022 •

edited

Loading