-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update manifests wg readme #720
update manifests wg readme #720
Conversation
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@kubeflow/kubeflow-steering-committee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating Manifests WG readme.
You might need to update the wgs.yaml like in this PR: #713 and run generator to re-create the README..
CC current Manifests WG Leads.
/assign @yanniszark @kimwnasptd @elikatsis @StefanoFioravanzo @PatrickXYS
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@andreyvelich @james-jwu i hope it is correct now and also in synchronization with kubeflow/manifests#2629 |
@StefanoFioravanzo can you give an explicit /lgtm again despite kubeflow/manifests#2629 (comment) |
/lgtm |
@elikatsis can you also approve again, despite kubeflow/manifests#2629 (comment) @PatrickXYS i think is gone from the project for a very long time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@andreyvelich @kimwnasptd
as requested in kubeflow/website#3724 (comment)