Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update manifests wg readme #720

Merged

Conversation

juliusvonkohout
Copy link
Member

@juliusvonkohout juliusvonkohout commented May 14, 2024

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Copy link
Member Author

@kubeflow/kubeflow-steering-committee

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating Manifests WG readme.

You might need to update the wgs.yaml like in this PR: #713 and run generator to re-create the README..

CC current Manifests WG Leads.

/assign @yanniszark @kimwnasptd @elikatsis @StefanoFioravanzo @PatrickXYS

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels May 14, 2024
@juliusvonkohout
Copy link
Member Author

@andreyvelich @james-jwu i hope it is correct now and also in synchronization with kubeflow/manifests#2629

@juliusvonkohout
Copy link
Member Author

@StefanoFioravanzo can you give an explicit /lgtm again despite kubeflow/manifests#2629 (comment)

@StefanoFioravanzo
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label May 17, 2024
@juliusvonkohout
Copy link
Member Author

@elikatsis can you also approve again, despite kubeflow/manifests#2629 (comment)

@PatrickXYS i think is gone from the project for a very long time.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ecaa1c3 into kubeflow:master May 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants