-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OWNERS #2629
Update OWNERS #2629
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@elikatsis Since you did not contribute as maintainer in the last 3 years AFAIK, are you still active or do you want to become active again in the near future in this repository? |
Reduce to active maintainers, since most new contributers are confused if maintainers do not respond, but are listed in their PRs as approvers. Signed-off-by: juliusvonkohout <juliusvonkohout@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
5d484ad
to
3a626bb
Compare
@jbottum @johnugeorge @terrytangyuan what do you think? |
i am also looking at getting maybe @kromanow94 and other active contributors as subproject maintainers in the long term. I think whoever contributes in some way consistently is a good candidate. |
LGTM @juliusvonkohout |
Hello, thanks for tackling this. In kubeflow/kubeflow we've introduced the concept of emeritus approvers (which is a common practice). Would it make sense to do it here as well? See kubeflow/kubeflow#7402 |
/lgtm |
Follow up chore of kubeflow/manifests#2629 and kubeflow/kubeflow#7402
Done in #2630 |
Follow up chore of kubeflow/manifests#2629 and kubeflow/kubeflow#7402 Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
/lgtm |
Follow up chore of kubeflow/manifests#2629 and kubeflow/kubeflow#7402 Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Reduce to active maintainers, since most new contributors are confused if maintainers do not respond, but are listed in their PRs as approvers.
The latest commit from the removed approvers is 3 years old 7f8e6d8
CC @andreyvelich and KSC
CC @kubeflow/wg-manifests-leads @kimwnasptd @rimolive
Here is an example of the problem: