Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OWNERS #2629

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Update OWNERS #2629

merged 1 commit into from
Feb 27, 2024

Conversation

juliusvonkohout
Copy link
Member

@juliusvonkohout juliusvonkohout commented Feb 27, 2024

Reduce to active maintainers, since most new contributors are confused if maintainers do not respond, but are listed in their PRs as approvers.

The latest commit from the removed approvers is 3 years old 7f8e6d8

CC @andreyvelich and KSC

CC @kubeflow/wg-manifests-leads @kimwnasptd @rimolive

Here is an example of the problem:

grafik

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member Author

juliusvonkohout commented Feb 27, 2024

@elikatsis
@PatrickXYS
@StefanoFioravanzo
@yanniszark

Since you did not contribute as maintainer in the last 3 years AFAIK, are you still active or do you want to become active again in the near future in this repository?

Reduce to active maintainers, since most new contributers are confused if maintainers do not respond, but are listed in their PRs as approvers.

Signed-off-by: juliusvonkohout <juliusvonkohout@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Copy link
Member Author

@jbottum @johnugeorge @terrytangyuan what do you think?

@juliusvonkohout
Copy link
Member Author

i am also looking at getting maybe @kromanow94 and other active contributors as subproject maintainers in the long term. I think whoever contributes in some way consistently is a good candidate.

@johnugeorge
Copy link
Member

LGTM @juliusvonkohout

@elikatsis
Copy link
Member

Hello, thanks for tackling this.

In kubeflow/kubeflow we've introduced the concept of emeritus approvers (which is a common practice). Would it make sense to do it here as well? See kubeflow/kubeflow#7402

@rimolive
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 27, 2024
@google-oss-prow google-oss-prow bot merged commit f36b608 into master Feb 27, 2024
7 checks passed
juliusvonkohout added a commit to juliusvonkohout/internal-acls that referenced this pull request Feb 28, 2024
@juliusvonkohout
Copy link
Member Author

Hello, thanks for tackling this.

In kubeflow/kubeflow we've introduced the concept of emeritus approvers (which is a common practice). Would it make sense to do it here as well? See kubeflow/kubeflow#7402

Done in #2630

juliusvonkohout added a commit to juliusvonkohout/internal-acls that referenced this pull request Feb 28, 2024
Follow up chore of kubeflow/manifests#2629 and kubeflow/kubeflow#7402

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout juliusvonkohout deleted the juliusvonkohout-patch-2 branch February 28, 2024 19:30
@StefanoFioravanzo
Copy link
Member

/lgtm

google-oss-prow bot pushed a commit to kubeflow/internal-acls that referenced this pull request Feb 29, 2024
Follow up chore of kubeflow/manifests#2629 and kubeflow/kubeflow#7402

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants