Skip to content

Commit

Permalink
chore: Remove dep ensure in CI (#525)
Browse files Browse the repository at this point in the history
* chore: Move unit test before image building in v1alpha2

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Move python suggestions build to dep

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* chore: Move more layers to dep

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* chore: Add dep and remove depensure in CI

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Run setup cluster later

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Address comments

Signed-off-by: Ce Gao <gaoce@caicloud.io>
  • Loading branch information
gaocegege authored and k8s-ci-robot committed May 15, 2019
1 parent cbd84c6 commit f626d4b
Show file tree
Hide file tree
Showing 4,101 changed files with 1,469,766 additions and 139 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,3 @@ ehthumbs_vista.db

## Recycle Bin used on file shares
$RECYCLE.BIN/

## Vendor packages
vendor/
1 change: 0 additions & 1 deletion test/scripts/v1alpha1/create-cluster.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ gcloud auth activate-service-account --key-file=${GOOGLE_APPLICATION_CREDENTIALS
echo "Creating GPU cluster"
gcloud --project ${PROJECT} beta container clusters create ${CLUSTER_NAME} \
--zone ${ZONE} \
--accelerator type=nvidia-tesla-k80,count=1 \
--cluster-version 1.11
echo "Configuring kubectl"
gcloud --project ${PROJECT} container clusters get-credentials ${CLUSTER_NAME} \
Expand Down
38 changes: 0 additions & 38 deletions test/scripts/v1alpha1/get-vendor-packages.sh

This file was deleted.

1 change: 0 additions & 1 deletion test/scripts/v1alpha2/create-cluster.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ gcloud auth activate-service-account --key-file=${GOOGLE_APPLICATION_CREDENTIALS
echo "Creating GPU cluster"
gcloud --project ${PROJECT} beta container clusters create ${CLUSTER_NAME} \
--zone ${ZONE} \
--accelerator type=nvidia-tesla-k80,count=1 \
--cluster-version 1.11
echo "Configuring kubectl"
gcloud --project ${PROJECT} container clusters get-credentials ${CLUSTER_NAME} \
Expand Down
38 changes: 0 additions & 38 deletions test/scripts/v1alpha2/get-vendor-packages.sh

This file was deleted.

40 changes: 13 additions & 27 deletions test/workflows/components/workflows-v1alpha1.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -204,12 +204,18 @@
template: "checkout",
}],
[
{
name: "dep-ensure",
template: "dep-ensure",
}
],
[
{
name: "python-tests",
template: "python-tests",
},
{
name: "build-suggestion-bo",
template: "build-suggestion-bo",
},
{
name: "build-suggestion-nasrl",
template: "build-suggestion-nasrl",
},
{
name: "build-manager",
template: "build-manager",
Expand All @@ -234,14 +240,6 @@
name: "build-suggestion-hyperband",
template: "build-suggestion-hyperband",
},
{
name: "build-suggestion-bo",
template: "build-suggestion-bo",
},
{
name: "build-suggestion-nasrl",
template: "build-suggestion-nasrl",
},
{
name: "build-earlystopping-median",
template: "build-earlystopping-median",
Expand All @@ -255,8 +253,7 @@
template: "create-pr-symlink",
},
],
[ // Setup cluster needs to run after build because we depend on the chart
// created by the build statement.
[
{
name: "setup-cluster",
template: "setup-cluster",
Expand All @@ -267,14 +264,6 @@
name: "unit-test",
template: "unit-test",
},
],
[
{
name: "python-tests",
template: "python-tests",
},
],
[
{
name: "run-tests",
template: "run-tests",
Expand Down Expand Up @@ -344,9 +333,6 @@
"copy_artifacts",
"--bucket=" + bucket,
]), // copy-artifacts
$.parts(namespace, name, overrides).e2e(prow_env, bucket).buildTemplate("dep-ensure", testWorkerImage, [
"test/scripts/v1alpha1/get-vendor-packages.sh",
]), // dep ensure
$.parts(namespace, name, overrides).e2e(prow_env, bucket).buildTemplate("build-manager", testWorkerImage, [
"test/scripts/v1alpha1/build-manager.sh",
]), // build-manager
Expand Down
48 changes: 17 additions & 31 deletions test/workflows/components/workflows-v1alpha2.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -204,12 +204,22 @@
template: "checkout",
}],
[
{
name: "dep-ensure",
template: "dep-ensure",
}
],
[
{
name: "python-tests",
template: "python-tests",
},
{
name: "build-suggestion-bo",
template: "build-suggestion-bo",
},
{
name: "build-suggestion-nasrl",
template: "build-suggestion-nasrl",
},
{
name: "unit-test",
template: "unit-test",
},
{
name: "build-manager",
template: "build-manager",
Expand All @@ -234,14 +244,6 @@
name: "build-suggestion-hyperband",
template: "build-suggestion-hyperband",
},
{
name: "build-suggestion-bo",
template: "build-suggestion-bo",
},
{
name: "build-suggestion-nasrl",
template: "build-suggestion-nasrl",
},
{
name: "build-earlystopping-median",
template: "build-earlystopping-median",
Expand All @@ -255,25 +257,12 @@
template: "create-pr-symlink",
},
],
[ // Setup cluster needs to run after build because we depend on the chart
// created by the build statement.
[
{
name: "setup-cluster",
template: "setup-cluster",
},
],
[
{
name: "unit-test",
template: "unit-test",
},
],
[
{
name: "python-tests",
template: "python-tests",
},
],
[
{
name: "run-tests",
Expand Down Expand Up @@ -344,9 +333,6 @@
"copy_artifacts",
"--bucket=" + bucket,
]), // copy-artifacts
$.parts(namespace, name, overrides).e2e(prow_env, bucket).buildTemplate("dep-ensure", testWorkerImage, [
"test/scripts/v1alpha2/get-vendor-packages.sh",
]), // dep ensure
$.parts(namespace, name, overrides).e2e(prow_env, bucket).buildTemplate("build-manager", testWorkerImage, [
"test/scripts/v1alpha2/build-manager.sh",
]), // build-manager
Expand Down
15 changes: 15 additions & 0 deletions vendor/cloud.google.com/go/AUTHORS

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit f626d4b

Please sign in to comment.