chore: Remove dep ensure in CI #525
Conversation
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hougangliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hougangliu PTAL nasrl and bo are python based algorithms. Thus we can build it before the dep ensure. |
|
/lgtm |
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
|
/hold |
Signed-off-by: Ce Gao <gaoce@caicloud.io>
gaocegege
changed the title
Signed-off-by: Ce Gao <gaoce@caicloud.io>
|
/hold cancel |
| @@ -267,14 +264,6 @@ | |||
| name: "unit-test", | |||
There was a problem hiding this comment.
unit tests not changed in v1alpha1?
There was a problem hiding this comment.
We cannot change it, because v1alpha1 unit test should be run after the cluster is created.
| template: "dep-ensure", | ||
| } | ||
| ], | ||
| [ |
There was a problem hiding this comment.
remove build template line also?
|
/lgtm |
Signed-off-by: Ce Gao <gaoce@caicloud.io>
|
/lgtm |
|
/retest |
|
@gaocegege: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Ce Gao gaoce@caicloud.io
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note:
This change is