Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Add WorkerStatus to GetMetrics and remove unused items #110

Merged
merged 2 commits into from
Jun 13, 2018

Conversation

YujiOshima
Copy link
Contributor

Changes

  • Add WorkerStatus to GetMetrics
  • Remove default_suggestion_algorithm and default_early_stopping_algorithm from StudyConfig.
    • It will move to StudyController
  • Remove Status from Trial
    • Trial doesn't have status. It's in Worker.

cc @libbyandhelen
/assign @gaocegege

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
@YujiOshima
Copy link
Contributor Author

/retest

@gaocegege
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 14963b0 into kubeflow:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants