Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken client-example.go #125

Closed
wants to merge 4 commits into from

Conversation

vinaykakade
Copy link
Contributor

With the recent changes in the repo (#110), I found that client-example.go no longer works. There are two issues:
(1) With having 'matrics\n - accuracy' in study-config, the CreateStudy request no longer is successful. Until the underlying cause is found/fixed, removing it from study-config. Let me know in case replacing it with something else works.
(2) Even after the workers terminate successfully, the client-example.go is no longer able to detect their termination and keeps on running in an infinite loop. Reverted to the original terminal condition change which works correctly.

/assign @YujiOshima

Vinay Kakade added 3 commits June 20, 2018 09:57
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: yujioshima

Assign the PR to them by writing /assign @yujioshima in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@YujiOshima
Copy link
Contributor

I have no error on client-example.go.
Maybe there is some mismatch between client and server.
Which docker image do you use for vizier-core?

@lluunn
Copy link
Contributor

lluunn commented Jun 22, 2018

I was also able to run client-example.go (last week)

@vinaykakade
Copy link
Contributor Author

Thanks, I'll check for the mismatch between client and server.

@jlewi
Copy link
Contributor

jlewi commented Jul 24, 2018

/ok-to-test

@jlewi
Copy link
Contributor

jlewi commented Jul 24, 2018

@vinaykakade Were you successful?

@vinaykakade
Copy link
Contributor Author

Yes, was able to run it long ago. Apologies for not reporting this sooner. Will close this PR.

@wukong1992
Copy link
Contributor

@vinaykakade How did you solve it?

@vinaykakade
Copy link
Contributor Author

The issue was mismatched images in dockerhub and the tip of master. I had to rebuild the images, upload them to an image repository we use, and point the manifest for vizier-core to pull the image from our repository instead of dockerhub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants