manifests: Remove Application CR #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreyvelich
reviewed
Apr 1, 2021
| @@ -29,7 +29,6 @@ resources: | |||
| # Cert-manager certificate for webhooks | |||
| - certificate.yaml | |||
| # Kubeflow Katib components. | |||
| - ../katib-with-kubeflow/katib-application.yaml | |||
There was a problem hiding this comment.
Should we also delete also this label:
?| @@ -29,7 +29,6 @@ resources: | |||
| - ../../components/webhook/rbac.yaml | |||
| - ../../components/webhook/webhooks.yaml | |||
| # Kubeflow Katib components. | |||
| - katib-application.yaml | |||
yanniszark
force-pushed
the
feature-remove-application-cr
branch
from
c789f9c to
dbced9c
Compare
Remove Application CR as per kubeflow/manifests#1715 Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
yanniszark
force-pushed
the
feature-remove-application-cr
branch
from
dbced9c to
08083ca
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, yanniszark The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
google-oss-robot
pushed a commit
that referenced
this pull request
Apr 1, 2021
…ry pick of #1507 on release-0.11. #1507: manifests: Remove Application CR (#1509) Remove Application CR as per: kubeflow/manifests#1715 Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Application CR as per kubeflow/manifests#1715