Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifests: Remove Application CR #1507

Merged
merged 1 commit into from
Apr 1, 2021
Merged

manifests: Remove Application CR #1507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions manifests/v1beta1/installs/katib-with-kubeflow-cert-manager/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ resources:
# Cert-manager certificate for webhooks
- certificate.yaml
# Kubeflow Katib components.
- ../katib-with-kubeflow/katib-application.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also delete also this label:

katib/manifests/v1beta1/installs/katib-with-kubeflow-cert-manager/kustomization.yaml

Lines 60 to 61 in c789f9c

commonLabels:
app.kubernetes.io/component: katib
?

- ../katib-with-kubeflow/kubeflow-katib-roles.yaml
- ../katib-with-kubeflow/ui-virtual-service.yaml
images:
Expand Down Expand Up @@ -58,9 +57,6 @@ patchesJson6902:
kind: PersistentVolumeClaim
namespace: kubeflow

commonLabels:
app.kubernetes.io/component: katib

vars:
- fieldref:
fieldPath: metadata.namespace
Expand Down
50 changes: 0 additions & 50 deletions manifests/v1beta1/installs/katib-with-kubeflow/katib-application.yaml
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions manifests/v1beta1/installs/katib-with-kubeflow/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ resources:
- ../../components/webhook/rbac.yaml
- ../../components/webhook/webhooks.yaml
# Kubeflow Katib components.
- katib-application.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above.

- kubeflow-katib-roles.yaml
- ui-virtual-service.yaml
images:
Expand Down Expand Up @@ -57,9 +56,6 @@ patchesJson6902:
kind: PersistentVolumeClaim
namespace: kubeflow

commonLabels:
app.kubernetes.io/component: katib

vars:
- fieldref:
fieldPath: metadata.namespace
Expand Down