Use golangci-lint as linter for Go

[tenzen-y]

What this PR does / why we need it:

• Replace golint to golangci-lint.

If we enable all default items in golangci-lint, we will receive a lot of lint errors. Although, I think It might be better to fix all lint errors.
What do you think? @andreyvelich @gaocegege @johnugeorge

Ref:

• default linters
• lint errors

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1670

[aws-kf-ci-bot]

Hi @tenzen-y. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tenzen-y]

/assign
/cc @andreyvelich @johnugeorge

[andreyvelich]

Thank you for taking this @tenzen-y!

Although, I think It might be better to fix all lint errors.

Yes, it would be great if we could fix them in this PR.

[andreyvelich]

/ok-to-test

[gaocegege]

If we enable all default items in golangci-lint, we will receive a lot of lint errors. Although, I think It might be better to fix all lint errors.

I have no objection to it.

[tenzen-y]

Thank you for your comment! @andreyvelich @gaocegege
I'd like to fix all lint errors in this PR!

/hold

[andreyvelich]

Maybe, I guess fixed the following issues without separating test managers in this PR.

You think handling some errors can help with it ?

[tenzen-y]

Maybe, I guess fixed the following issues without separating test managers in this PR.

You think handling some errors can help with it ?

As discussed in #1649, I also think the tests were sometimes failing due to the heavy load on the manager.
In this PR, I fixed the unnecessary repetition of resource creation and deletion. As a result, the load on the manager has been reduced and crashes have become less frequent. In the future, as more test code is added, the possibility of another crash will increase.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[tenzen-y]

@googlebot I consent.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[tenzen-y]

@andreyvelich
Could you comment @googlebot I consent., please?

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[tenzen-y]

/retest

[andreyvelich]

As a result, the load on the manager has been reduced and crashes have become less frequent. In the future, as more test code is added, the possibility of another crash will increase

Makes sense, let's see if it helps.

[andreyvelich]

@googlebot I consent.

[tenzen-y]

/unhold

[andreyvelich]

Thank you for doing this @tenzen-y!
/lgtm
/assign @gaocegege @johnugeorge

[gaocegege]

There are some lint errors here https://github.com/kubeflow/katib/pull/1671/checks?check_run_id=3671380935

[tenzen-y]

There are some lint errors here https://github.com/kubeflow/katib/pull/1671/checks?check_run_id=3671380935

Thanks for the review! @gaocegege
I think it has been resolved in the latest test.

https://github.com/kubeflow/katib/pull/1671/checks?check_run_id=3680981981#step:5:1502

[gaocegege]

/lgtm
/approve

Thanks for your contribution! 🎉 👍

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gaocegege]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment