Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use golangci-lint as linter for Go #1671

Merged
merged 15 commits into from
Sep 24, 2021
Merged

Use golangci-lint as linter for Go #1671

merged 15 commits into from
Sep 24, 2021

Commits on Sep 21, 2021

  1. use golangci-lint as linter for Go instead of golint

    @tenzen-y
    tenzen-y committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    8b63cef View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. Update hack/verify-golangci-lint.sh 

    Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
    @tenzen-y @andreyvelich
    tenzen-y and andreyvelich authored Sep 22, 2021
    Configuration menu
    Copy the full SHA
    b2001c4 View commit details
    Browse the repository at this point in the history

  2. specify golangci-lint version 

    Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
    @tenzen-y @andreyvelich
    tenzen-y and andreyvelich authored Sep 22, 2021
    Configuration menu
    Copy the full SHA
    82f5923 View commit details
    Browse the repository at this point in the history

  3. fix echo comment 

    Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
    @tenzen-y @andreyvelich
    tenzen-y and andreyvelich authored Sep 22, 2021
    Configuration menu
    Copy the full SHA
    5aeadf2 View commit details
    Browse the repository at this point in the history

  4. fix echo comment 

    Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
    @tenzen-y @andreyvelich
    tenzen-y and andreyvelich authored Sep 22, 2021
    Configuration menu
    Copy the full SHA
    b90f88e View commit details
    Browse the repository at this point in the history

  5. fix lint

    @tenzen-y
    tenzen-y committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    e9c3afd View commit details
    Browse the repository at this point in the history

  6. fix gofmt

    @tenzen-y
    tenzen-y committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    bcbc13a View commit details
    Browse the repository at this point in the history

  7. fix generated codes

    @tenzen-y
    tenzen-y committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    92a68ad View commit details
    Browse the repository at this point in the history

  8. close the connection for early stopping without using defer

    @tenzen-y
    tenzen-y committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    e821e5f View commit details
    Browse the repository at this point in the history

  9. do not create or delete any resources within gomega.Eventually

    @tenzen-y
    tenzen-y committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    f68c376 View commit details
    Browse the repository at this point in the history

  10. add condition to return error in getKatibJob func

    @tenzen-y
    tenzen-y committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    2a589a4 View commit details
    Browse the repository at this point in the history

  11. remove comment out lines

    @tenzen-y
    tenzen-y committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    d1550f5 View commit details
    Browse the repository at this point in the history

  12. simplify some codes 

    Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
    @tenzen-y @andreyvelich
    tenzen-y and andreyvelich authored Sep 22, 2021
    Configuration menu
    Copy the full SHA
    d207842 View commit details
    Browse the repository at this point in the history

  13. remove an unnecessary variable 

    Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
    @tenzen-y @andreyvelich
    tenzen-y and andreyvelich authored Sep 22, 2021
    Configuration menu
    Copy the full SHA
    ce87b40 View commit details
    Browse the repository at this point in the history

  14. fix golangci-lint error 

    Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
    @tenzen-y @andreyvelich
    tenzen-y and andreyvelich committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    3ab64fa View commit details
    Browse the repository at this point in the history