-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Python and Pytorch versions for some examples #1906
Upgrade Python and Pytorch versions for some examples #1906
Conversation
@johnugeorge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
It built well in amd64, cpu, linux
aef5b13
to
ee5738c
Compare
ee5738c
to
dc089b7
Compare
I will do force-push to re-run Go Test. |
dc089b7
to
224a6ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anencore94, johnugeorge, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since the base image is no longer built with GPU support, CUDA acceleration is not available. Since we were using this image in our tests, they broke. It's misleading because the mnist.py still tries to use cuda but it will never be available. |
Thanks for your comment @djmcgreal-cc. @johnugeorge |
@tenzen-y cuda image resources are not available with Github actions? |
@johnugeorge Since the image with CUDA support size is very heavy as shown below, we will face Not CUDA support image size: 639.63 MB |
@tenzen-y We can then defer this building step till we find a solution. eg: CI in AWS Other option, is to manually build and push image as changes are not frequent to this build |
@johnugeorge So, we cannot confirm that the image works, but we can provide the image with support CUDA built in gh-actions. |
@tenzen-y I feel, that should be ok for now |
@johnugeorge |
What this PR does / why we need it:
I upgraded Python and Pytorch versions for
darts-cnn-cifar10
andpytorch-mnist
examples.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1883
Checklist: