Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the pytorch-mnist with GPU support container image #1916

Merged

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jul 16, 2022

What this PR does / why we need it:
As discussed in this PR comments, I added the pytorch-mnist with GPU support container image and modified image name pytorch-mnist to pytorch-mnist-cpu.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Jul 16, 2022

Coverage Status

Coverage increased (+0.07%) to 73.068% when pulling 6d54642 on tenzen-y:add-pytorch-mnist-gpu-image into 8f182c2 on kubeflow:master.

@tenzen-y
Copy link
Member Author

I have confirmed that Dockerfile is buildable in the following container images.

@tenzen-y tenzen-y changed the title [WIP] Add the pytorch-mnist with GPU support container image Add the pytorch-mnist with GPU support container image Jul 16, 2022
@tenzen-y
Copy link
Member Author

/cc @johnugeorge @djmcgreal-cc

I will cherry-pick this PR for the release-0.14 branch after this PR is merged.

@google-oss-prow google-oss-prow bot requested a review from johnugeorge July 16, 2022 12:34
@google-oss-prow
Copy link

@tenzen-y: GitHub didn't allow me to request PR reviews from the following users: djmcgreal-cc.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @johnugeorge @djmcgreal-cc

I will cherry-pick this PR for the release-0.14 branch after this PR is merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants