-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Format code #1979
UI: Format code #1979
Conversation
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
@johnugeorge I see that the task for checking the frontend code format now succeeds. But the task for https://github.com/kubeflow/katib/actions/runs/3311965464/jobs/5468058581 |
@kimwnasptd Thanks for helping review this PR! We need to restart the failed CI job since the |
@kubeflow/wg-automl-leads Can you restart the failed GH-Actions Job? |
/assign @kimwnasptd |
lastly, is it expected to run the full testing suite on just a change in the frontend? Or maybe @orfeas-k needs to rebase the PR on top of the latest master(?) |
@kimwnasptd This is due to a flaky test. Can you lgtm when ready? |
Awesome! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd, orfeas-k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR fixes unformatted code that was introduced in #1974 and which breaks other PRs as noted here #1977 (comment).