Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Format code #1979

Merged

Conversation

orfeas-k
Copy link
Contributor

This PR fixes unformatted code that was introduced in #1974 and which breaks other PRs as noted here #1977 (comment).

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 73.545% when pulling 404681c on arrikto:feature-orfeas-k-format-code into 4299856 on kubeflow:master.

@kimwnasptd
Copy link
Member

kimwnasptd commented Oct 24, 2022

@johnugeorge I see that the task for checking the frontend code format now succeeds. But the task for Go Test /Unit Test (1.22.1) (pull request) is now failing. Do you have any more insights?

https://github.com/kubeflow/katib/actions/runs/3311965464/jobs/5468058581

@tenzen-y
Copy link
Member

@johnugeorge I see that the task for checking the frontend code format now succeeds. But the task for Go Test /Unit Test (1.22.1) (pull request) is now failing. Do you have any more insights?

https://github.com/kubeflow/katib/actions/runs/3311965464/jobs/5468058581

@kimwnasptd Thanks for helping review this PR!

We need to restart the failed CI job since the Go test / Unit Test is flaky.
ref: #1649

@tenzen-y
Copy link
Member

@kubeflow/wg-automl-leads Can you restart the failed GH-Actions Job?

@tenzen-y
Copy link
Member

/assign @kimwnasptd

@kimwnasptd
Copy link
Member

lastly, is it expected to run the full testing suite on just a change in the frontend?

Or maybe @orfeas-k needs to rebase the PR on top of the latest master(?)

@johnugeorge
Copy link
Member

@kimwnasptd This is due to a flaky test. Can you lgtm when ready?

@kimwnasptd
Copy link
Member

Awesome!

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Oct 24, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd, orfeas-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8cbaf85 into kubeflow:master Oct 24, 2022
@kimwnasptd kimwnasptd deleted the feature-orfeas-k-format-code branch October 24, 2022 14:38
@kimwnasptd kimwnasptd mentioned this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants