-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kwa(front): Add UI tests with Cypress #2088
kwa(front): Add UI tests with Cypress #2088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orfeas-k While the README
section instructs the user to use npm run e2e
or npm run e2e-ci-all
to run the UI tests, the npm
scripts in package.json
are different. Is this expected?
- Install Cypress & npm scripts for UI tests - Remove Protractor files - Add README.md file to include UI tests instructions - Modify .gitignore Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Add UI tests with Cypress to check that: - New Experiment form page loads template without errors. - Index page * has an "Experiments" title * lists experiments without errors * renders every experiment name into the table * renders properly Status icon for all experiments Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
dcb939a
to
b644959
Compare
@elenzio9 Good observation! I fixed this and pushed again. |
Other than that it looks great! Thank you @orfeas-k! |
The failed job @kubeflow/wg-automl-leads Can you restart the failed GH-Actions Job? |
/assign @kimwnasptd |
@tenzen-y since this PR touches some of the GH Actions we'll also need you to approve the PR to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd, orfeas-k, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds UI tests with Cypress for functionalities of the KWA frontend. More specifically, they check that:
Everything implementation-specific (mock API, node version etc) mentioned in the VWA UI tests PR stand for this one too.