Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ansi-html and react-scripts in /pkg/ui/v1beta1/frontend #1986

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 26, 2022

Removes ansi-html. It's no longer used after updating ancestor dependency react-scripts. These dependencies need to be updated together.

Removes ansi-html

Updates react-scripts from 3.2.0 to 5.0.1

Changelog

Sourced from react-scripts's changelog.

3.4.4 (2020-10-20)

v3.4.4 release bumps resolve-url-loader to a version for which npm audit does not report a vulnerability. Note that this vulnerability did not affect Create React App projects, so this change is only necessary to satisfy auditing tools.

Migrating from 3.4.3 to 3.4.4

Inside any created project that has not been ejected, run:

npm install --save --save-exact react-scripts@3.4.4

or

yarn add --exact react-scripts@3.4.4

3.4.3 (2020-08-12)

v3.4.3 release bumps terser-webpack-plugin to a version for which npm audit does not report a vulnerability. Note that this vulnerability did not affect Create React App projects, so this change is only necessary to satisfy auditing tools.

Migrating from 3.4.2 to 3.4.3

Inside any created project that has not been ejected, run:

npm install --save --save-exact react-scripts@3.4.3

or

yarn add --exact react-scripts@3.4.3

3.4.2 (2020-08-11)

v3.4.2 release bumps webpack-dev-server to a version for which npm audit does not report a vulnerability. Note that this vulnerability did not affect Create React App projects, so this change is only necessary to satisfy auditing tools.

Migrating from 3.4.1 to 3.4.2

Inside any created project that has not been ejected, run:

npm install --save --save-exact react-scripts@3.4.2

or

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Removes [ansi-html](https://github.com/Tjatse/ansi-html). It's no longer used after updating ancestor dependency [react-scripts](https://github.com/facebook/create-react-app/tree/HEAD/packages/react-scripts). These dependencies need to be updated together.


Removes `ansi-html`

Updates `react-scripts` from 3.2.0 to 5.0.1
- [Release notes](https://github.com/facebook/create-react-app/releases)
- [Changelog](https://github.com/facebook/create-react-app/blob/main/CHANGELOG-3.x.md)
- [Commits](https://github.com/facebook/create-react-app/commits/react-scripts@5.0.1/packages/react-scripts)

---
updated-dependencies:
- dependency-name: ansi-html
  dependency-type: indirect
- dependency-name: react-scripts
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 26, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 73.431% when pulling df53f1f on dependabot/npm_and_yarn/pkg/ui/v1beta1/frontend/ansi-html-and-react-scripts--removed into e7f8eb1 on master.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, dependabot[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member

@kubeflow/wg-automl-leads Can you restart the failure jobs?

@andreyvelich
Copy link
Member

@DomFleischmann @knkski @ca-scribner Please can you take a look why Charmed test fails with this error:

Run juju status
  juju status
  shell: /usr/bin/bash -e {0}
ERROR No controllers registered.

Please either create a new controller using "juju bootstrap" or connect to
another controller that you have been given access to using "juju register".

@google-oss-prow google-oss-prow bot merged commit aee2109 into master Oct 27, 2022
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/pkg/ui/v1beta1/frontend/ansi-html-and-react-scripts--removed branch October 27, 2022 13:35
@tenzen-y
Copy link
Member

tenzen-y commented Oct 28, 2022

@DomFleischmann @knkski @ca-scribner Please can you take a look why Charmed test fails with this error:

Run juju status
  juju status
  shell: /usr/bin/bash -e {0}
ERROR No controllers registered.

Please either create a new controller using "juju bootstrap" or connect to
another controller that you have been given access to using "juju register".

@andreyvelich I guess we can not build the katib-ui image (not katib-newui) from this PR, and then Charmed test failed.

images=("katib-controller" "katib-ui" "katib-db-manager")
folders=("katib-controller" "ui" "db-manager")

https://github.com/kubeflow/katib/actions/runs/3330395200/jobs/5514741368#step:6:15

I think we need to consider whether to fix the katib-ui (not katib-newui) or replace katib-ui for Charmed katib with katib-new-ui.

WDYT?

@andreyvelich
Copy link
Member

Thanks for the notice @tenzen-y!

I think we need to consider whether to fix the katib-ui (not katib-newui) or replace katib-ui for Charmed katib with katib-new-ui.

Yes, we should use katib-new-ui for Charmed actions.

@tenzen-y
Copy link
Member

Thanks for the notice @tenzen-y!

I think we need to consider whether to fix the katib-ui (not katib-newui) or replace katib-ui for Charmed katib with katib-new-ui.

Yes, we should use katib-new-ui for Charmed actions.

@andreyvelich I agree with you.
I’ll create a PR and do ping to team Canonical on that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants