Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump shell-quote and react-scripts in /pkg/ui/v1beta1/frontend #1984

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 25, 2022

Bumps shell-quote to 1.7.4 and updates ancestor dependency react-scripts. These dependencies need to be updated together.

Updates shell-quote from 1.7.2 to 1.7.4

Changelog

Sourced from shell-quote's changelog.

v1.7.4 - 2022-10-12

Merged

Commits

  • [eslint] fix indentation and whitespace aaa9d1f
  • [eslint] additional cleanup 397cb62
  • [meta] add auto-changelog 497fca5
  • [actions] add reusable workflows 4763c36
  • [eslint] add eslint 6ee1437
  • [readme] rename, add badges 7eb5134
  • [meta] update URLs 67381b6
  • [meta] create FUNDING.yml; add funding in package.json 8641572
  • [meta] use npmignore to autogenerate an npmignore file 2e2007a
  • Only apps should have lockfiles f97411e
  • [Dev Deps] update tape 051f608
  • [meta] add safe-publish-latest 18cadf9
  • [Tests] add aud in posttest dc1cc12

1.7.3

  • Fix a security issue where the regex for windows drive letters allowed some shell meta-characters to escape the quoting rules. (CVE-2021-42740)
Commits
  • 5409e72 v1.7.4
  • 4763c36 [actions] add reusable workflows
  • 8641572 [meta] create FUNDING.yml; add funding in package.json
  • 497fca5 [meta] add auto-changelog
  • 7eb5134 [readme] rename, add badges
  • 67381b6 [meta] update URLs
  • 2e2007a [meta] use npmignore to autogenerate an npmignore file
  • 18cadf9 [meta] add safe-publish-latest
  • 397cb62 [eslint] additional cleanup
  • aaa9d1f [eslint] fix indentation and whitespace
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by ljharb, a new releaser for shell-quote since your current version.


Updates react-scripts from 3.2.0 to 5.0.1

Changelog

Sourced from react-scripts's changelog.

3.4.4 (2020-10-20)

v3.4.4 release bumps resolve-url-loader to a version for which npm audit does not report a vulnerability. Note that this vulnerability did not affect Create React App projects, so this change is only necessary to satisfy auditing tools.

Migrating from 3.4.3 to 3.4.4

Inside any created project that has not been ejected, run:

npm install --save --save-exact react-scripts@3.4.4

or

yarn add --exact react-scripts@3.4.4

3.4.3 (2020-08-12)

v3.4.3 release bumps terser-webpack-plugin to a version for which npm audit does not report a vulnerability. Note that this vulnerability did not affect Create React App projects, so this change is only necessary to satisfy auditing tools.

Migrating from 3.4.2 to 3.4.3

Inside any created project that has not been ejected, run:

npm install --save --save-exact react-scripts@3.4.3

or

yarn add --exact react-scripts@3.4.3

3.4.2 (2020-08-11)

v3.4.2 release bumps webpack-dev-server to a version for which npm audit does not report a vulnerability. Note that this vulnerability did not affect Create React App projects, so this change is only necessary to satisfy auditing tools.

Migrating from 3.4.1 to 3.4.2

Inside any created project that has not been ejected, run:

npm install --save --save-exact react-scripts@3.4.2

or

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 25, 2022
@dependabot dependabot bot requested a review from tenzen-y October 25, 2022 13:04
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 25, 2022
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/pkg/ui/v1beta1/frontend/shell-quote-and-react-scripts-1.7.4 branch from 3020575 to 2da7c9d Compare October 25, 2022 16:29
@google-oss-prow google-oss-prow bot removed the lgtm label Oct 25, 2022
Bumps [shell-quote](https://github.com/ljharb/shell-quote) to 1.7.4 and updates ancestor dependency [react-scripts](https://github.com/facebook/create-react-app/tree/HEAD/packages/react-scripts). These dependencies need to be updated together.


Updates `shell-quote` from 1.7.2 to 1.7.4
- [Release notes](https://github.com/ljharb/shell-quote/releases)
- [Changelog](https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md)
- [Commits](ljharb/shell-quote@v1.7.2...v1.7.4)

Updates `react-scripts` from 3.2.0 to 5.0.1
- [Release notes](https://github.com/facebook/create-react-app/releases)
- [Changelog](https://github.com/facebook/create-react-app/blob/main/CHANGELOG-3.x.md)
- [Commits](https://github.com/facebook/create-react-app/commits/react-scripts@5.0.1/packages/react-scripts)

---
updated-dependencies:
- dependency-name: shell-quote
  dependency-type: indirect
- dependency-name: react-scripts
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/pkg/ui/v1beta1/frontend/shell-quote-and-react-scripts-1.7.4 branch from 2da7c9d to 1ec820d Compare October 26, 2022 06:32
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 26, 2022
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 73.431% when pulling 1ec820d on dependabot/npm_and_yarn/pkg/ui/v1beta1/frontend/shell-quote-and-react-scripts-1.7.4 into 0253a01 on master.

@johnugeorge
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, dependabot[bot], johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andreyvelich,johnugeorge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 26, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/pkg/ui/v1beta1/frontend/shell-quote-and-react-scripts-1.7.4 branch October 26, 2022 15:25
@tenzen-y
Copy link
Member

@johnugeorge Can I re-open this PR?

@andreyvelich
Copy link
Member

@tenzen-y Let's wait until this one will be merged: #1986

@tenzen-y
Copy link
Member

@tenzen-y Let's wait until this one will be merged: #1986

I see. I got it.

@johnugeorge
Copy link
Member

Also, we need to remove ui folder and switch to new-ui in the coming release

@tenzen-y
Copy link
Member

Also, we need to remove ui folder and switch to new-ui in the coming release

sgtm

@andreyvelich
Copy link
Member

@johnugeorge We need to discuss with @kimwnasptd the remaining items from here: https://github.com/kubeflow/katib/projects/1.
Some of the functionality are still missing in the new UI (e.g. filter/sorting Trials)

@johnugeorge
Copy link
Member

Yes. Agree. However, it is not blocking us to do the switch as code is not shared anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants