chore: Refactor nasenvelopenet #492
Conversation
|
/assign @johnugeorge @richardsliu |
|
@gaocegege #494 duplicate with this PR, please enable nasenvelopenet test step in test/workflows/components/workflows-v1alpha1.libsonnet. |
|
@hougangliu Thanks, added. Not aware of your PR, sorry about it. |
Never mind, it seems we fix it at same time :) |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
scripts/v1alpha1/build.sh
Outdated
| @@ -40,10 +40,10 @@ docker build -t ${PREFIX}/v1alpha1/suggestion-grid -f ${CMD_PREFIX}/suggestion/g | |||
| docker build -t ${PREFIX}/v1alpha1/suggestion-hyperband -f ${CMD_PREFIX}/suggestion/hyperband/v1alpha1/Dockerfile . | |||
| docker build -t ${PREFIX}/v1alpha1/suggestion-bayesianoptimization -f ${CMD_PREFIX}/suggestion/bayesianoptimization/v1alpha1/Dockerfile . | |||
| docker build -t ${PREFIX}/v1alpha1/suggestion-nasrl -f ${CMD_PREFIX}/suggestion/nasrl/v1alpha1/Dockerfile . | |||
| docker build -t ${PREFIX}/suggestion-nasenvelopenet -f ${CMD_PREFIX}/suggestion/nasenvelopenet/v1alpha1/Dockerfile . | |||
There was a problem hiding this comment.
Should it be docker build -t ${PREFIX}/v1alpha1/suggestion-nasenvelopenet here?
|
|
||
| cp cmd/suggestion/nasenvelopenet/Dockerfile . | ||
| gcloud builds submit . --tag=${REGISTRY}/${REPO_NAME}/suggestion-nasenvelopenet:${VERSION} --project=${PROJECT} | ||
| gcloud container images add-tag --quiet ${REGISTRY}/${REPO_NAME}/suggestion-nasenvelopenet:${VERSION} ${REGISTRY}/${REPO_NAME}/suggestion-nasenvelopenet:latest --verbosity=info |
There was a problem hiding this comment.
I think, here as well.
cp cmd/suggestion/v1alpha1/nasenvelopenet/Dockerfile .
gcloud builds submit . --tag=${REGISTRY}/${REPO_NAME}/v1alpha1/suggestion-nasenvelopenet:${VERSION} --project=${PROJECT}
gcloud container images add-tag --quiet ${REGISTRY}/${REPO_NAME}/v1alpha1/suggestion-nasenvelopenet:${VERSION} ${REGISTRY}/${REPO_NAME}/suggestion-nasenvelopenet:latest --verbosity=info
|
|
||
| cp cmd/suggestion/nasenvelopenet/Dockerfile . | ||
| gcloud builds submit . --tag=${REGISTRY}/${REPO_NAME}/suggestion-nasenvelopenet:${VERSION} --project=${PROJECT} | ||
| gcloud container images add-tag --quiet ${REGISTRY}/${REPO_NAME}/suggestion-nasenvelopenet:${VERSION} ${REGISTRY}/${REPO_NAME}/suggestion-nasenvelopenet:latest --verbosity=info |
There was a problem hiding this comment.
And here:
cp cmd/suggestion/v1alpha2/nasenvelopenet/Dockerfile .
gcloud builds submit . --tag=${REGISTRY}/${REPO_NAME}/v1alpha2/suggestion-nasenvelopenet:${VERSION} --project=${PROJECT}
gcloud container images add-tag --quiet ${REGISTRY}/${REPO_NAME}/v1alpha2/suggestion-nasenvelopenet:${VERSION} ${REGISTRY}/${REPO_NAME}/suggestion-nasenvelopenet:latest --verbosity=info
|
/retest |
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
|
/retest |
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
|
Updated to sync the upstream master. PTAL @johnugeorge @hougangliu |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hougangliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nasenvelopenet does not follow our convention. This PR is to refactor it.
Signed-off-by: Ce Gao gaoce@caicloud.io
This change is