Restructuring docker files to build images per version #527
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Some changes are not added to avoid merge conflicts because of on going PR
|
|
Gotcha, thanks. I will do it for envelopenet |
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
| RUN GRPC_HEALTH_PROBE_VERSION=v0.2.0 && \ | ||
| wget -qO/bin/grpc_health_probe https://github.com/grpc-ecosystem/grpc-health-probe/releases/download/${GRPC_HEALTH_PROBE_VERSION}/grpc_health_probe-linux-amd64 && \ | ||
| chmod +x /bin/grpc_health_probe | ||
| COPY --from=build-env /go/src/github.com/kubeflow/katib/cmd/manager/katib-manager /app/ |
There was a problem hiding this comment.
This should be katib-manager.v1alpha2.
| # Copy the controller-manager into a thin image | ||
| FROM alpine:3.7 | ||
| WORKDIR /app | ||
| COPY --from=build-env /go/src/github.com/kubeflow/katib/cmd/katib-controller/katib-controller . |
There was a problem hiding this comment.
This should be katib-controller.v1alpha2. Or we can remove the ".v1alpha2" from line 9 above.
|
|
||
| FROM alpine:3.7 | ||
| WORKDIR /app | ||
| COPY --from=build-env /go/src/github.com/kubeflow/katib/cmd/manager-rest/katib-manager-rest /app/ |
There was a problem hiding this comment.
katib-manager-rest.v1alpha2
|
@johnugeorge Should I make the same with Dockerfiles for the UI? |
|
@andreyvelich I think we should follow the same conventions for all components. That way we can easily find all v1alpha2 related images. |
|
@richardsliu Alright, will make changes in the UI PR. |
|
Please rebase to remove dep-ensure step in CI |
|
Also need to update the python script paths in |
|
/retest |
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
Dockerfiles are copied to each version so that each version is built independently.
This change is