Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename counter metrics #942

Merged
merged 1 commit into from
Dec 4, 2019
Merged

rename counter metrics #942

merged 1 commit into from
Dec 4, 2019

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Dec 1, 2019 •
edited by jlewi
Loading

Signed-off-by: yeya24 yb532204897@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

See kubeflow/training-operator#1055, add _total suffix.

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @yeya24. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gaocegege
Copy link
Member

/ok-to-test

/lgtm

It is more prometheus friendly.

@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

@yeya24
Copy link
Contributor Author

yeya24 commented Dec 2, 2019

/retest

6 similar comments
@yeya24
Copy link
Contributor Author

yeya24 commented Dec 2, 2019

/retest

@yeya24
Copy link
Contributor Author

yeya24 commented Dec 2, 2019

/retest

@gaocegege
Copy link
Member

/retest

@yeya24
Copy link
Contributor Author

yeya24 commented Dec 2, 2019

/retest

@yeya24
Copy link
Contributor Author

yeya24 commented Dec 2, 2019

/retest

@yeya24
Copy link
Contributor Author

yeya24 commented Dec 2, 2019

/retest

@hougangliu
Copy link
Member

/retest
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hougangliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yeya24
Copy link
Contributor Author

yeya24 commented Dec 4, 2019

@hougangliu This test still failed in file-metricscollector. Is it better to fix #945 first? WDYT?

@johnugeorge
Copy link
Member

/retest

@johnugeorge
Copy link
Member

Can you rebase?

@yeya24
rename counter metrics
98953e5 
Signed-off-by: yeya24 <yb532204897@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 4, 2019
@johnugeorge
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 8a443c4 into kubeflow:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinan-zhou jinan-zhou Awaiting requested review from jinan-zhou

@garganubhav garganubhav Awaiting requested review from garganubhav

Assignees

@johnugeorge johnugeorge

@gaocegege gaocegege

Labels
approved lgtm ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yeya24 @k8s-ci-robot @gaocegege @hougangliu @johnugeorge