add total suffix in counter metrics

[yeya24]

Signed-off-by: yeya24 yb532204897@gmail.com

I am wondering if this pr will cause compatibility problem. But I think we should follow the metrics naming . All counter metrics need add suffix total.

---

This change is 

[k8s-ci-robot]

Hi @yeya24. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yeya24]

@krishnadurai Please take a look. 😄

[coveralls]

Coverage remained the same at 76.744% when pulling c29af7c on yeya24:rename-metrics into c47c5ca on kubeflow:master.

[johnugeorge]

Do you mean, compatibility problems with existing deployments?

[yeya24]

@johnugeorge Exactly. But add this suffix is important and we can know what the metric type is from its name.

[gaocegege]

I think so. The PR LGTM.

/lgtm

Thanks for your contribution! 🎉 👍

[johnugeorge]

/ok-to-test

[yeya24]

Forget to update the docs I will update it tomorrow.

[johnugeorge]

Thanks @yeya24 Can you add the docs in the same PR

[yeya24]

@johnugeorge Done. PTAL

[krishnadurai]

@yeya24 thanks for pointing this out. This will have a compatibility issue as v1 release will report on the earlier name, though I think the name change will always come with a new deployment.
The impact should be low.
Can you please make a note of the name change in the docs?

[krishnadurai]

Is this formatting change intentional?

[yeya24]

Yes. This common.JobCondition is redundant and could be remove.

[yeya24]

@krishnadurai I' m not sure if this note is enough. PTAL. Thanks!

[krishnadurai]

This note is fine.

/lgtm

[johnugeorge]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [johnugeorge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment