-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Kind 1.27 and fix the integration tests #2637
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
ea88609
to
814909e
Compare
@andreyvelich in kubeflow/katib#2256 (comment) says that they already support 1.27. Maybe our tests are outdated See also #2602 |
manifests/.github/workflows/katib_kind_test.yaml Lines 45 to 58 in 39bac59
and or might have to be updated |
Yea, that's right. The katib already supports the K8s v1.27. |
@tenzen-y can you provide us a modern test file than that finishes in 2 minutes on Kubernetes 1.27? |
We're using the same test as #2637 (comment) |
@juliusvonkohout Oh, I found that this repository uses the
But the image wouldn't work well since the MXNet project has already been closed. So, once kubeflow/katib#2267 is merged, I can share a new example with you. |
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@tenzen-y i crafted something very fast from your latest PR, since the tests must run in 2 minutes. Seems to be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM perspective of Katib.
@@ -1,78 +1,56 @@ | |||
--- | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--- |
This is duplicated.
* update to Kind 1.27 Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update katib test Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update katib test Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * increase test pipeline timeout from 60 to 120 seconds Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Update to Kind 1.27 such that we have a supported upgrade path from 1.8.0 on Kubernetes 1.26 -> 1.8.1 on Kubernetes 1.26 -> 1.8.1 on Kubernetes 1.27 -> 1.9 on Kubernetes 1.27 -> Kubernetes 1.29