Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MXNet examples #2267

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Mar 2, 2024

What this PR does / why we need it:
I removed MXNet example and then, I replaced MXNet with PyTorch in examples, and test data.

This PR is blocking all PRs since this PR fixed the current stopped-working CI.
Blocked:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2261

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member Author

tenzen-y commented Mar 2, 2024

/hold

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y force-pushed the remove-mxnet-examples branch from 407bac5 to 465fc9b Compare March 2, 2024 20:39
@tenzen-y
Copy link
Member Author

tenzen-y commented Mar 2, 2024

Ready for the review.

/assign @andreyvelich @johnugeorge

@tenzen-y
Copy link
Member Author

tenzen-y commented Mar 4, 2024

/hold cancel

@johnugeorge
Copy link
Member

/lgtm

Thanks @tenzen-y

@google-oss-prow google-oss-prow bot added the lgtm label Mar 4, 2024
@google-oss-prow google-oss-prow bot merged commit fc858d1 into kubeflow:master Mar 4, 2024
62 checks passed
@tenzen-y tenzen-y deleted the remove-mxnet-examples branch March 4, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove MXNet example
3 participants