Tektoncd

[kkasravi]

Which issue is resolved by this Pull Request:
Prerequiste to kubeflow/testing#424

Description of your changes:
Adds tektoncd crds and install to manifests - similar to argo.

The tektoncd installation has the crds split out into a separate kustomize target
since kustomize v2.0.3 doesn't do ordering. The tektoncd manifest adheres to best practices
and is similar to other kustomize targets where crds are separated.

Checklist:

• Unit tests have been rebuilt:
  1. cd manifests/tests
  2. make generate
  3. make test

---

This change is 

[jlewi]

@kkasravi I don't think there is more work to get tekton installed in our test clusters; (i.e. lets not close kubeflow/testing#424 after this PR is merged).

Test infra is here:
https://github.com/kubeflow/testing/tree/master/test-infra

So once we have a kustomize package for tekton we need to update that along with the instructions to actually get tekton deployed on our clusters.

[jlewi]

Reviewable status: 0 of 36 files reviewed, 1 unresolved discussion (waiting on @jlewi, @kkasravi, and @richardsliu)

---

tektoncd/tektoncd-pipelines/base/kfctl_pr.yaml, line 2 at r2 (raw file):

---
apiVersion: tekton.dev/v1alpha1

Can I suggest moving any Kubeflow specific tasks/pipelines into a separate PR?
Maybe the first PR can just be a kustomize package for installing tekton?

[kkasravi]

sure, i'll separate the others into a different PR

[krishnadurai]

/cc @krishnadurai

[jlewi]

@kkasravi Is this PR ready for review? If it is could you update the PR description please to capture what this PR is doing? e.g. I don't think this PR is installing Tekton on our test clusters. I think this PR is just defining a kustomize manifest for installing tekton and possibly some tekton tasks and pipelines for Kubeflow.

[kkasravi]

@kkasravi Is this PR ready for review? If it is could you update the PR description please to capture what this PR is doing? e.g. I don't think this PR is installing Tekton on our test clusters. I think this PR is just defining a kustomize manifest for installing tekton and possibly some tekton tasks and pipelines for Kubeflow.

yes this is ready to merge. I did a rebase from main and a make generate;make test
I also updated the PR description to make it clear this is just adding tekton crds, install manifests.
They haven't been included in the test environment or elsewhere.

[kkasravi]

/assign @jlewi

[jlewi]

/lgtm
/approve
/hold

@kkasravi Could you update the PR description to explain why you went with creating manifests for the individual components? I believe customize has a custom resource that can be used to install all of the Tekton components.

I don't think its worth changing right now; if this PR works then lets go with it. It would be good to document though why we went with this approach for future reference. i.e. if the reason is simply that we didn't know about the CR then lets just capture that in the PR description so that we know that it might be worth investigating later.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jlewi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kkasravi]

/hold cancel