Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kustomize package for tekton #1198

Closed
jlewi opened this issue Aug 15, 2019 · 14 comments
Closed

kustomize package for tekton #1198

jlewi opened this issue Aug 15, 2019 · 14 comments
Labels
kind/question Issues or PRs that are questions around the project or a particular feature lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@jlewi
Copy link

jlewi commented Aug 15, 2019

Have you considered creating a kustomize package for TektonCD?

The Kubeflow project is starting to test TektonCD and we are heavy users of kustomize so we are creating a kustomize package.

kubeflow/manifests#264

Someone could potentially upstream that if it makes sense.

/cc @kkasravi

@vdemeester vdemeester added the kind/question Issues or PRs that are questions around the project or a particular feature label Aug 16, 2019
@bobcatfish
Copy link
Collaborator

@jlewi is this still something kubeflow wants/needs? I'm not very familiar with kustomize packages so if this is something you'd want I'd benefit from knowing what the package would provide. (And maybe it would be useful for our dogfooding efforts also? we use kustomize a lot for that! @afrittoli @vdemeester )

@afrittoli
Copy link
Member

We have a kustomize plugin within the plumbing repo, but it's only for trigger resources. I guess we could have a general package, but I'm not aware of how this is then made available to others?

@jlewi
Copy link
Author

jlewi commented Apr 9, 2020

The advantage of kustomize packages is that it makes it easy for us to compose applications into a stack of applications.

I would like to start including Tekton in Kubeflow stacks because we have a lot of places where we'd like to start using Tekton. In particular, I'd like to start being able to use Task's to define reusable ML tasks.

kubeflow/testing#613 - Tasks for running notebooks
kubeflow/fairing#454 - Use tasks for container building from within cluster/notebooks
kubeflow/katib#906 - Use Tekton tasks as "templates" for hyperpameter tuning.

These efforts aren't really blocked on a kustomize package for Tekton. We rolled our own
https://github.com/kubeflow/manifests/tree/master/tektoncd

The primary motivation for creating an upstream kustomize package in Tekton would be to upstream the maintenance cost of the Tekton manifests.

For example, each time we ship a Kubeflow version we'd probably like to ship the latest Tekton release. Right now we would have to go in and update the Kubeflow Tekton manifest to point to latest docker images.

There's a couple ways we could do this

  1. I think kustomize supports git/https links - so we could just point at YAMLs in the Tekton repos
  2. We could just periodically copy the upstream manifest to our repo

I think the problem with #1 is that from a user perspective remote dependencies could create a problem; e.g. if your running on prem and need to clone our repo to on prem. If our manfiests start having remote dependencies that becomes a lot more problematic.

So I think #2 is probably better. It creates toil but I think this is easy to automate. It would be great to have a Tekton Task/Tekton pipeline to copy some set of files from one repo to another repo and open up a PR.

We have started creating reusable tasks to these types of task.
https://github.com/kubeflow/testing/blob/master/apps-cd/pipelines/base/task.yaml

@tekton-robot
Copy link
Collaborator

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 13, 2020
@tekton-robot
Copy link
Collaborator

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 13, 2020
@vdemeester
Copy link
Member

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

@tekton-robot tekton-robot reopened this Aug 17, 2020
@tekton-robot
Copy link
Collaborator

@vdemeester: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 17, 2020
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 15, 2020
@moto-timo
Copy link

I would like to see a kustomize package be available.

@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 9, 2021
@tekton-robot
Copy link
Collaborator

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Collaborator

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Issues or PRs that are questions around the project or a particular feature lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants