Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

add total suffix in counter metrics #201

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Aug 7, 2019

Signed-off-by: yeya24 yb532204897@gmail.com

Mirror PR for tf-operator : kubeflow/training-operator#1055

@k8s-ci-robot
Copy link

Hi @yeya24. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: yeya24 <yb532204897@gmail.com>
@yeya24 yeya24 force-pushed the add-total-suffix branch from 8045f0a to e24e81f Compare August 7, 2019 13:26
@johnugeorge
Copy link
Member

/ok-to-test

@coveralls
Copy link

coveralls commented Aug 7, 2019

Coverage Status

Coverage decreased (-14.1%) to 71.135% when pulling e24e81f on yeya24:add-total-suffix into ca2c9c4 on kubeflow:master.

@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f85242a into kubeflow:master Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants