Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add crds drift check between chart/ and manifest/ #1272

Merged
merged 2 commits into from
May 25, 2021

Conversation

ImpSy
Copy link
Contributor

@ImpSy ImpSy commented May 25, 2021

Hello,

This PR address the issue of crds drift between chart/ and manifest/ encountered in #1262
I've also delete redundant element in .github/workflows/main.yaml

This PR comes with an open question:
Should we keep Travis-ci, since everything that it does is also check by GitHub workflow ?

Copy link
Collaborator

@liyinan926 liyinan926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@liyinan926 liyinan926 merged commit 075e538 into kubeflow:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants