Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add crds drift check between chart/ and manifest/ #1272

Merged
merged 2 commits into from
May 25, 2021
Merged

add crds drift check between chart/ and manifest/ #1272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a0e8a4
add crds drift check between chart/ and manifest/
ImpSy May 25, 2021
6d0a0f6
fixup! add crds drift check between chart/ and manifest/
ImpSy May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ jobs:
- name: unit tests
run: make test

- name: integration tests
run: make test

it:
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -68,6 +65,9 @@ jobs:
- name: Run chart-testing (lint)
run: ct lint

- name: Detect CRDs drift between chart and manifest
run: make detect-crds-drift

- name: Create kind cluster
uses: helm/kind-action@v1.0.0

Expand Down
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ fmt-check: clean
@echo "running fmt check"
./.travis.gofmt.sh

detect-crds-drift:
diff -q charts/spark-operator-chart/crds manifest/crds

clean:
@echo "cleaning up caches and output"
go clean -cache -testcache -r -x ./... 2>&1 >/dev/null
Expand Down