-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken integration test CI #2109
Fix broken integration test CI #2109
Conversation
Signed-off-by: Yi Chen <github@chenyicn.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vara-bonthu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Yi Chen <github@chenyicn.net> (cherry picked from commit 6ff204a)
Signed-off-by: Yi Chen <github@chenyicn.net>
* Update workflow and docs for releasing Spark operator (#2089) * Update .helmignore Signed-off-by: Yi Chen <github@chenyicn.net> * Add release docs Signed-off-by: Yi Chen <github@chenyicn.net> * Update release workflow Signed-off-by: Yi Chen <github@chenyicn.net> * Update integration test workflow Signed-off-by: Yi Chen <github@chenyicn.net> * Add workflow for pushing tag when VERSION file changes Signed-off-by: Yi Chen <github@chenyicn.net> * Update Signed-off-by: Yi Chen <github@chenyicn.net> * Remove the leading 'v' from chart version Signed-off-by: Yi Chen <github@chenyicn.net> * Update docker image tags Signed-off-by: Yi Chen <github@chenyicn.net> --------- Signed-off-by: Yi Chen <github@chenyicn.net> (cherry picked from commit a3ec8f1) * Fix broken integration test CI (#2109) Signed-off-by: Yi Chen <github@chenyicn.net> (cherry picked from commit 6ff204a) * Fix CI: environment variable BRANCH is missed (#2111) Signed-off-by: Yi Chen <github@chenyicn.net> (cherry picked from commit e2693f1)
Signed-off-by: Yi Chen <github@chenyicn.net>
* Update workflow and docs for releasing Spark operator (kubeflow#2089) * Update .helmignore Signed-off-by: Yi Chen <github@chenyicn.net> * Add release docs Signed-off-by: Yi Chen <github@chenyicn.net> * Update release workflow Signed-off-by: Yi Chen <github@chenyicn.net> * Update integration test workflow Signed-off-by: Yi Chen <github@chenyicn.net> * Add workflow for pushing tag when VERSION file changes Signed-off-by: Yi Chen <github@chenyicn.net> * Update Signed-off-by: Yi Chen <github@chenyicn.net> * Remove the leading 'v' from chart version Signed-off-by: Yi Chen <github@chenyicn.net> * Update docker image tags Signed-off-by: Yi Chen <github@chenyicn.net> --------- Signed-off-by: Yi Chen <github@chenyicn.net> (cherry picked from commit a3ec8f1) * Fix broken integration test CI (kubeflow#2109) Signed-off-by: Yi Chen <github@chenyicn.net> (cherry picked from commit 6ff204a) * Fix CI: environment variable BRANCH is missed (kubeflow#2111) Signed-off-by: Yi Chen <github@chenyicn.net> (cherry picked from commit e2693f1)
Purpose of this PR
When integration test workflow is triggered by push event, the CI failed https://github.com/kubeflow/spark-operator/actions/runs/10198309429/job/28212951826#logs. The
origin/ref/heads/
prefix of branch name should be stripped.Proposed changes:
github.ref
withgithub.ref_name
Change Category
Indicate the type of change by marking the applicable boxes:
Rationale
Checklist
Before submitting your PR, please review the following:
Additional Notes