Fix CI: environment variable BRANCH is missed #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Chen <github@chenyicn.net>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuchaoran2011 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ChenYi015
added a commit
to ChenYi015/spark-operator
that referenced
this pull request
Aug 2, 2024
Signed-off-by: Yi Chen <github@chenyicn.net> (cherry picked from commit e2693f1)
8 tasks
YanivKunda
pushed a commit
to YanivKunda/spark-operator
that referenced
this pull request
Aug 5, 2024
Signed-off-by: Yi Chen <github@chenyicn.net>
google-oss-prow bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
* Update workflow and docs for releasing Spark operator (#2089) * Update .helmignore Signed-off-by: Yi Chen <github@chenyicn.net> * Add release docs Signed-off-by: Yi Chen <github@chenyicn.net> * Update release workflow Signed-off-by: Yi Chen <github@chenyicn.net> * Update integration test workflow Signed-off-by: Yi Chen <github@chenyicn.net> * Add workflow for pushing tag when VERSION file changes Signed-off-by: Yi Chen <github@chenyicn.net> * Update Signed-off-by: Yi Chen <github@chenyicn.net> * Remove the leading 'v' from chart version Signed-off-by: Yi Chen <github@chenyicn.net> * Update docker image tags Signed-off-by: Yi Chen <github@chenyicn.net> --------- Signed-off-by: Yi Chen <github@chenyicn.net> (cherry picked from commit a3ec8f1) * Fix broken integration test CI (#2109) Signed-off-by: Yi Chen <github@chenyicn.net> (cherry picked from commit 6ff204a) * Fix CI: environment variable BRANCH is missed (#2111) Signed-off-by: Yi Chen <github@chenyicn.net> (cherry picked from commit e2693f1)
sigmarkarl
pushed a commit
to spotinst/spark-on-k8s-operator
that referenced
this pull request
Aug 7, 2024
Signed-off-by: Yi Chen <github@chenyicn.net>
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
* Update workflow and docs for releasing Spark operator (kubeflow#2089) * Update .helmignore Signed-off-by: Yi Chen <github@chenyicn.net> * Add release docs Signed-off-by: Yi Chen <github@chenyicn.net> * Update release workflow Signed-off-by: Yi Chen <github@chenyicn.net> * Update integration test workflow Signed-off-by: Yi Chen <github@chenyicn.net> * Add workflow for pushing tag when VERSION file changes Signed-off-by: Yi Chen <github@chenyicn.net> * Update Signed-off-by: Yi Chen <github@chenyicn.net> * Remove the leading 'v' from chart version Signed-off-by: Yi Chen <github@chenyicn.net> * Update docker image tags Signed-off-by: Yi Chen <github@chenyicn.net> --------- Signed-off-by: Yi Chen <github@chenyicn.net> (cherry picked from commit a3ec8f1) * Fix broken integration test CI (kubeflow#2109) Signed-off-by: Yi Chen <github@chenyicn.net> (cherry picked from commit 6ff204a) * Fix CI: environment variable BRANCH is missed (kubeflow#2111) Signed-off-by: Yi Chen <github@chenyicn.net> (cherry picked from commit e2693f1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
The integration test CI on the release branch failed due to missed
BRANCHenvironment variable.Proposed changes:
BRANCHenvironment variableChange Category
Indicate the type of change by marking the applicable boxes:
Rationale
Checklist
Before submitting your PR, please review the following:
Additional Notes