Skip to content

Commit

Permalink
Directory for junit file for notebooks is incorrect (#716)
Browse files Browse the repository at this point in the history
* We need to upload the junits to the artifacts/junit_* directory

Related to GoogleCloudPlatform/kubeflow-distribution#65
  • Loading branch information
jlewi authored Jul 3, 2020
1 parent 6fd81e2 commit c2af63b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ spec:
- name: notebook-output
value: $(params.notebook-output)
- name: artifacts-gcs
value: $(params.artifacts-gcs)
value: $(params.artifacts-gcs)/artifacts/junit_$(params.test-target-name)
- name: testing-cluster-pattern
value: $(params.testing-cluster-pattern)
- name: testing-cluster-location
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ spec:
- name: notebook-output
value: $(params.notebook-output)
- name: artifacts-gcs
value: $(params.artifacts-gcs)
value: $(params.artifacts-gcs)/artifacts/junit_$(params.test-target-name)
- name: testing-cluster-pattern
value: $(params.testing-cluster-pattern)
- name: testing-cluster-location
Expand Down
2 changes: 1 addition & 1 deletion tekton/templates/pipelines/notebook-test-pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ spec:
- name: notebook-output
value: $(params.notebook-output)
- name: artifacts-gcs
value: $(params.artifacts-gcs)
value: $(params.artifacts-gcs)/artifacts/junit_$(params.test-target-name)
- name: testing-cluster-pattern
value: $(params.testing-cluster-pattern)
- name: testing-cluster-location
Expand Down

0 comments on commit c2af63b

Please sign in to comment.