Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory for junit file for notebooks is incorrect #716

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Jul 2, 2020

  • We need to upload the junits to the artifacts/junit_* directory

Related to GoogleCloudPlatform/kubeflow-distribution#65

@kubeflow-bot
Copy link

This change is Reviewable

@jlewi
Copy link
Contributor Author

jlewi commented Jul 2, 2020

/assign @Bobgy

* We need to upload the junits to the artifacts/junit_* directory

Related to GoogleCloudPlatform/kubeflow-distribution#65
@NikeNano
Copy link
Member

NikeNano commented Jul 2, 2020

/lgtm

@Bobgy
Copy link
Contributor

Bobgy commented Jul 3, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c2af63b into kubeflow:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants