-
Notifications
You must be signed in to change notification settings - Fork 185
Make dependancy adal optional #108
Make dependancy adal optional #108
Conversation
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
==========================================
- Coverage 92.04% 91.74% -0.31%
==========================================
Files 13 13
Lines 1182 1187 +5
==========================================
+ Hits 1088 1089 +1
- Misses 94 98 +4
Continue to review full report at Codecov.
|
BTW, there is a similar PR: #101 |
cfae0d6
to
375befb
Compare
Per our slack discussion on Oct 31st, I asked you if you wanted to hand over the issue and you said yes. That was why I started to work on it and opened a PR. If you want to work on it again, go straight ahead. I don’t mind - to me reviewing is just important as submitting a fix. However in the future please remember what you have said so that this situation does not happen any more. |
Yes @micw523 you asked me the issue you were working on but I think you are confusing this issue with another one you asked for
I think we should start working on issue after assigning ourselves. I would have stopped working on it if you mentioned that you are working on it. No worries, if you still want to work on it please assign yourself to that issue and I'm happy to help you with the issue :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: iamneha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This version [0] makes the adal package optional [1], which also removes its dependency on the cryptography package. It also fixes a thread pool issue [2] allowing us to remove the workaround we had in place. [0]: https://github.com/kubernetes-client/python/blob/master/CHANGELOG.md#v900 [1]: kubernetes-client/python-base#108 [2]: kubernetes-client/gen#91 Change-Id: I55aa8b97483b118fbde7e11df817ad8330da9bf1
Fixes issue :kubernetes-client/python/issues#645
To fix this issue:
adal
from requirementsextras_require
in setup.pyFix for 1 and 2 is kubernetes-client/python/pull#668