-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making the dependency adal optinal #645
Comments
@roycaihw can you please assign me this issue |
/assign @iamneha |
@yliaog: GitHub didn't allow me to assign the following users: iamneha. Note that only kubernetes-client members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I were sure I were doing something wrong when making Alpine-based images, but the packages you mentioned makes alpine3.7 images about 300 MB just to make sure the |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi folks,
I'm currently using the version 'kubernetes==8.0.0a1' and encountered that the ADAL dependency was added. This makes it more difficult to package a container image as it pulls additional dependencies and the image size increases. The following tweet illustrates it perfectly.
https://twitter.com/try_except_/status/1029843228613402627
It would be nice if the dependency is only added under extra_require.
It has also the effect that, when I'm building an alpine image I have to install additional packages like [ build-base, libffi-dev, openssl-dev] or in another case [gcc build-base linux-headers python3-dev ca-certificates python3-dev libffi-dev libressl-dev], which bloats the container further.
I'm currently not sure where the dependency is used.
The text was updated successfully, but these errors were encountered: