Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the dependency adal optinal #645

Closed
atolj opened this issue Oct 12, 2018 · 10 comments
Closed

Making the dependency adal optinal #645

atolj opened this issue Oct 12, 2018 · 10 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/design Categorizes issue or PR as related to design. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@atolj
Copy link

atolj commented Oct 12, 2018

Hi folks,

I'm currently using the version 'kubernetes==8.0.0a1' and encountered that the ADAL dependency was added. This makes it more difficult to package a container image as it pulls additional dependencies and the image size increases. The following tweet illustrates it perfectly.

https://twitter.com/try_except_/status/1029843228613402627

It would be nice if the dependency is only added under extra_require.

It has also the effect that, when I'm building an alpine image I have to install additional packages like [ build-base, libffi-dev, openssl-dev] or in another case [gcc build-base linux-headers python3-dev ca-certificates python3-dev libffi-dev libressl-dev], which bloats the container further.

I'm currently not sure where the dependency is used.

@roycaihw
Copy link
Member

/assign @roycaihw
cc @mbohlool @yliaog

@roycaihw roycaihw added kind/design Categorizes issue or PR as related to design. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 12, 2018
@iamneha
Copy link
Contributor

iamneha commented Oct 24, 2018

@roycaihw can you please assign me this issue

@yliaog
Copy link
Contributor

yliaog commented Oct 24, 2018

/assign @iamneha

@k8s-ci-robot
Copy link
Contributor

@yliaog: GitHub didn't allow me to assign the following users: iamneha.

Note that only kubernetes-client members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @iamneha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yliaog yliaog assigned roycaihw and unassigned roycaihw Oct 24, 2018
@iamneha
Copy link
Contributor

iamneha commented Oct 28, 2018

#668

@torgeirl
Copy link

It has also the effect that, when I'm building an alpine image I have to install additional packages like [ build-base, libffi-dev, openssl-dev] or in another case [gcc build-base linux-headers python3-dev ca-certificates python3-dev libffi-dev libressl-dev], which bloats the container further.

I were sure I were doing something wrong when making Alpine-based images, but the packages you mentioned makes alpine3.7 images about 300 MB just to make sure the kubernetes package is installed.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 26, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/design Categorizes issue or PR as related to design. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

7 participants