Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples use deprecated API since k8s v1.16 #967

Closed
3 tasks
micw523 opened this issue Sep 24, 2019 · 16 comments · Fixed by #1155
Closed
3 tasks

Examples use deprecated API since k8s v1.16 #967

micw523 opened this issue Sep 24, 2019 · 16 comments · Fixed by #1155
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.

Comments

@micw523
Copy link
Contributor

micw523 commented Sep 24, 2019

Link to the issue (please include a link to the specific documentation or example):
This is the non-critical part of #963

Description of the issue (please include outputs or screenshots if possible):
In k8s v1.16, a few old APIs got deprecated. See #966 and kubernetes/kubernetes#70672. Also see https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/
Need update:

  • In examples/notebooks, the notebook create_deployment.ipynb uses apps/v1beta1 API.
  • In examples/notebooks, the notebook intro_notebook.ipynb uses apps/v1beta1 API.

Could use an update:

  • The example ingress_create.py uses networking/v1beta1 API. This could be upgraded to networking/v1 API.

/assign

@micw523 micw523 added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 24, 2019
@micw523
Copy link
Contributor Author

micw523 commented Sep 24, 2019

/help
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@micw523:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 24, 2019
@yliaog
Copy link
Contributor

yliaog commented Oct 8, 2019

/assign @scottilee

@k8s-ci-robot
Copy link
Contributor

@yliaog: GitHub didn't allow me to assign the following users: scottilee.

Note that only kubernetes-client members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @scottilee

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rajibmitra
Copy link

rajibmitra commented Oct 30, 2019

I would like to take this if no one is working on it actively.

@rajibmitra
Copy link

/assign rajibmitra

@scottilee
Copy link
Contributor

@rajibmitra hey just checking in to see if you were able to make any progress on this?

@raunaqness
Copy link

Can I take this up? @scottilee

@rajibmitra rajibmitra removed their assignment Dec 10, 2019
@rajibmitra
Copy link

@scottilee I didn't get time to fix this , unassigned myself.
@raunaqness or @scottilee please feel free to work on this.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 9, 2020
@micw523
Copy link
Contributor Author

micw523 commented Mar 9, 2020

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 9, 2020
@moshevayner
Copy link
Member

Hey @micw523!
is anyone working on this issue?
If not- I'd love to help!

@tsusadivyago
Copy link

i would like to help

@moshevayner
Copy link
Member

/assign

@moshevayner
Copy link
Member

/remove-lifecycle stale

@moshevayner
Copy link
Member

/remove-lifecycle frozen

@k8s-ci-robot k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants