Address API Changes Introduced in k8s v1.16 #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
micw523
force-pushed
the
testfix116
branch
2 times, most recently
from
072f9ee
to
1aabc93
Compare
micw523
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
roycaihw
reviewed
Sep 24, 2019
| from kubernetes.e2e_test import base | ||
|
|
||
|
|
||
| class TestClientExtensions(unittest.TestCase): |
There was a problem hiding this comment.
do we have equivalent test for apps API?
k8s-ci-robot
added
size/M
roycaihw
reviewed
Sep 24, 2019
kubernetes/e2e_test/test_apps.py
Outdated
| kind: Deployment | ||
| metadata: | ||
| name: %s | ||
| spec: | ||
| replicas: 3 | ||
| selector: | ||
| matchLabels: |
There was a problem hiding this comment.
Fixed. The original indentation looked that way.
kubernetes/e2e_test/test_apps.py
Outdated
| @@ -56,28 +58,33 @@ def test_create_deployment(self): | |||
| self.assertIsNotNone(resp) | |||
|
|
|||
| options = v1_delete_options.V1DeleteOptions() | |||
| resp = api.delete_namespaced_deployment(name, 'default', body=options) | |||
| resp = api.delete_namespaced_deployment(name, 'default', body={}) | |||
There was a problem hiding this comment.
why don't we keep the v1 DeleteOptions?
There was a problem hiding this comment.
It's optional - I kept it just in case. I think sometime in the past, body was not optional for the delete methods so that was necessary. Now it is not.
micw523
force-pushed
the
testfix116
branch
2 times, most recently
from
038a75a
to
b4c9849
Compare
3 tasks
micw523
force-pushed
the
testfix116
branch
2 times, most recently
from
7985e52
to
13790f7
Compare
|
/assign @roycaihw |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: micw523, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
fabianvf
pushed a commit
to fabianvf/python
that referenced
this pull request
Feb 21, 2020
Address API Changes Introduced in k8s v1.16 (cherry picked from commit c310289)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #963 .
This PR: