Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command line arguments to configure leader election options in external-health-monitor-controller #89

Closed
xing-yang opened this issue Aug 18, 2021 · 2 comments · Fixed by #90
Closed

Add command line arguments to configure leader election options in external-health-monitor-controller #89

xing-yang opened this issue Aug 18, 2021 · 2 comments · Fixed by #90
Assignees
@deepakkinni

Comments

@xing-yang
Copy link
Contributor

The leader election package specified 3 variables that are related to the time interval of acquiring and renewing leases. We should allow these options to be configurable in external-health-monitor-controller. See detailed description in the following issue:
kubernetes-csi/external-provisioner#556

See a PR that addressed this:
kubernetes-csi/external-provisioner#643

We need to make the changes here:
https://github.com/kubernetes-csi/external-health-monitor/blob/master/cmd/csi-external-health-monitor-controller/main.go
@xing-yang
Copy link
Contributor Author

@deepakkinni Can you assign this to yourself? Thanks.

@deepakkinni
Copy link
Member

/assign

@deepakkinni deepakkinni mentioned this issue Aug 18, 2021
Merged
fengzixu pushed a commit to fengzixu/external-health-monitor that referenced this issue Oct 9, 2021
@pohly
Squashed 'release-tools/' changes from 4cf843f..a0f195c
63ae26b 
a0f195c Merge pull request kubernetes-csi#106 from msau42/fix-canary
7100c12 Only set staging registry when running canary job
b3c65f9 Merge pull request kubernetes-csi#99 from msau42/add-release-process
e53f3e8 Merge pull request kubernetes-csi#103 from msau42/fix-canary
d129462 Document new method for adding CI jobs are new K8s versions
e73c2ce Use staging registry for canary tests
2c09846 Add cleanup instructions to release-notes generation
60e1cd3 Merge pull request kubernetes-csi#98 from pohly/kubernetes-1-19-fixes
0979c09 prow.sh: fix E2E suite for Kubernetes >= 1.18
3b4a2f1 prow.sh: fix installing Go for Kubernetes 1.19.0
1fbb636 Merge pull request kubernetes-csi#97 from pohly/go-1.15
82d108a switch to Go 1.15
d8a2530 Merge pull request kubernetes-csi#95 from msau42/add-release-process
843bddc Add steps on promoting release images
0345a83 Merge pull request kubernetes-csi#94 from linux-on-ibm-z/bump-timeout
1fdf2d5 cloud build: bump timeout in Prow job
41ec6d1 Merge pull request kubernetes-csi#93 from animeshk08/patch-1
5a54e67 filter-junit: Fix gofmt error
0676fcb Merge pull request kubernetes-csi#92 from animeshk08/patch-1
36ea4ff filter-junit: Fix golint error
f5a4203 Merge pull request kubernetes-csi#91 from cyb70289/arm64
43e50d6 prow.sh: enable building arm64 image
0d5bd84 Merge pull request kubernetes-csi#90 from pohly/k8s-staging-sig-storage
3df86b7 cloud build: k8s-staging-sig-storage
c5fd961 Merge pull request kubernetes-csi#89 from pohly/cloud-build-binfmt
db0c2a7 cloud build: initialize support for running commands in Dockerfile
be902f4 Merge pull request kubernetes-csi#88 from pohly/multiarch-windows-fix
340e082 build.make: optional inclusion of Windows in multiarch images
5231f05 build.make: properly declare push-multiarch
4569f27 build.make: fix push-multiarch ambiguity
17dde9e Merge pull request kubernetes-csi#87 from pohly/cloud-build
bd41690 cloud build: initial set of shared files
9084fec Merge pull request kubernetes-csi#81 from msau42/add-release-process
6f2322e Update patch release notes generation command
0fcc3b1 Merge pull request kubernetes-csi#78 from ggriffiths/fix_csi_snapshotter_rbac_version_set
d8c76fe Support local snapshot RBAC for pull jobs
c1bdf5b Merge pull request kubernetes-csi#80 from msau42/add-release-process
ea1f94a update release tools instructions
152396e Merge pull request kubernetes-csi#77 from ggriffiths/snapshotter201_update
7edc146 Update snapshotter to version 2.0.1

git-subtree-dir: release-tools
git-subtree-split: a0f195cc2ddc2a1f07d4d3e46fc08187db358f94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepakkinni deepakkinni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add command line arguments to configure leader election options deepakkinni/external-health-monitor
2 participants
@xing-yang @deepakkinni