kubeconfig-in-cluster is not a secret #793
Conversation
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
k8s-ci-robot
added
size/S
|
coreosbot test this please |
|
Yeah this make sense to me. lgtm |
There was a problem hiding this comment.
@redbaron since #784 was merged do you mind updating the checkpointer e2e tests to match this PR?
https://github.com/kubernetes-incubator/bootkube/blob/master/e2e/checkpointer_test.go#L371
redbaron
force-pushed
the
kubeconfig-in-cluster-configmap
branch
from
3789c8f
to
8ac514b
Compare
|
coreosbot run e2e |
|
coreosbot run e2e-calico |
|
coreosbot run e2e |
1 similar comment
|
coreosbot run e2e |
|
@diegs , I have no visibility on what is failing :( |
|
@redbaron sorry, can you please rebase to pick up some test improvements I committed last week? They are still a little flaky but much less so than before. This PR doesn't look like it would cause any failures. |
|
Do you test branch or merge result? Looks like testing merge results would be more robust. I'll rebase in a moment |
redbaron
force-pushed
the
kubeconfig-in-cluster-configmap
branch
from
8ac514b
to
7911f2f
Compare
|
all green! |
|
@redbaron agree that testing merge results is better. Unfortunately the jenkins jobs for these tests are very old and don't work that way :-/ |
|
I think a team member has to say "coreosbot run e2e" after updates, in the last run, only 2 tests were green, there should be 4 (e2e tests were skipped) |
|
ugh, sorry, i thought that once admins test the patch then subsequent pushes to the PR trigger all the tests. |
There are no secrets in kubeconfig-in-cluster, so it should be a configmap really