This repository has been archived by the owner on Jul 30, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 224
e2e: make checkpointer tests more robust. #784
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
label
Nov 28, 2017
k8s-ci-robot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Nov 28, 2017
diegs
force-pushed
the
checkpointer-e2e
branch
2 times, most recently
from
November 29, 2017 00:03
dae5bf1
to
dfa7ae6
Compare
k8s-ci-robot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Nov 29, 2017
diegs
force-pushed
the
checkpointer-e2e
branch
2 times, most recently
from
December 5, 2017 10:49
e3860b0
to
3cd7975
Compare
diegs
force-pushed
the
checkpointer-e2e
branch
from
December 5, 2017 19:21
3cd7975
to
95d73f5
Compare
Note: includes commit from #778 |
cc @ericchiang |
diegs
force-pushed
the
checkpointer-e2e
branch
2 times, most recently
from
December 6, 2017 20:09
164b62e
to
d3a9f98
Compare
The checkpointer now only watches pods in kube-system (kubernetes-retired#774), so it doesn't need cluster wide permissions.
Instead of extending the existing checkpointer daemonset to run on worker nodes, start a new checkpointer daemonset instead. This makes sure that the existing checkpointer (on the apiserver) is not disturbed. Furthermore, this allows the checkpointer tests to work with the new checkpointer that is only allowed to look at its own namespace.
diegs
force-pushed
the
checkpointer-e2e
branch
from
December 7, 2017 23:56
d3a9f98
to
0955615
Compare
coreosbot run e2e |
dghubble
approved these changes
Dec 10, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is still flakiness, but this is valuable to unblock the checkpointer change to only watch a single namespace.
coreosbot run e2e |
In the most recent run the reboot test failed. Looks like the apiserver never came back. That is pretty concerning. I'll run some stress tests on that locally. |
coreosbot run e2e |
e2e didn't even run this time: |
coreosbot run e2e |
This was referenced Dec 11, 2017
dghubble
added a commit
to poseidon/terraform-render-bootstrap
that referenced
this pull request
Dec 12, 2017
* pod-checkpointer no longer needs to watch pods in all namespaces, it should only have permission to watch kube-system * kubernetes-retired/bootkube#784
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of extending the existing checkpointer daemonset to run on
worker nodes, start a new checkpointer daemonset instead. This makes
sure that the existing checkpointer (on the apiserver) is not disturbed.
Furthermore, this allows the checkpointer tests to work with the new
checkpointer that is only allowed to look at its own namespace.