Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

[WIP] Kube-batch perf test #597

Conversation

shivramsrivastava
Copy link
Contributor

What this PR does / why we need it:
This PR adds the scheduler_perf test to kube-batch, this is similar to the scheduler_perf test found in the k8s project for the default scheduler.

Special notes for your reviewer:

  1. This are the initial changes.

TODO:

  • Adding the test framework api-server with CRD support.
  • Adding Pod-Affinity/Anti-Affinity and the Node-Affinity/Anti-Affinity tests.
  • Updating the README
  • Running the test and generate sample graphs
  • Added the initial code and updated vendor.
  • Added methods to run kube-batch from within the perf test.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shivramsrivastava
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: k82cn

If they are not already assigned, you can assign the PR to them by writing /assign @k82cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 22, 2019
@shivramsrivastava
Copy link
Contributor Author

/assign @k82cn

@shivramsrivastava shivramsrivastava changed the title [WIP] Kube batch perf tes [WIP] Kube-batch perf test Feb 22, 2019
@@ -0,0 +1,142 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we copy code here? we should also use import for those package.

@liggitt
Copy link

liggitt commented Feb 22, 2019

/unassign

@k82cn
Copy link
Contributor

k82cn commented Feb 25, 2019

/uncc @liggitt @deads2k

@k82cn
Copy link
Contributor

k82cn commented Apr 4, 2019

@shivramsrivastava , are you still working on this?

@shivramsrivastava
Copy link
Contributor Author

I am putting an hold on this task for now, since i am unable to resolve the api-server issue for crd support.
I will take up others issues in the meantime.
If you have any suggestions on which issue to take let me know, please?

@shivramsrivastava
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2019
@k82cn
Copy link
Contributor

k82cn commented Apr 19, 2019

@TommyLike , @hzxuzhonghu , would you help to review this PR and get it done ASAP? we're testing the performance of kube-batch, and this is important for us.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 18, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 17, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants