Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Add Kubemark Benchmark Design Doc #616

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

Rajadeepan
Copy link
Contributor

What this PR does / why we need it:
This PR illustrates the Design Doc for kubemark Benchmark in Kube-Batch

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
#427

Special notes for your reviewer:
https://github.com/Rajadeepan/kube-batch/blob/doc/doc/design/Benchmark/kubemark/kubemark-benchmarking.md

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 3, 2019
@k8s-ci-robot k8s-ci-robot requested review from k82cn and tizhou86 March 3, 2019 15:11
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 3, 2019

## OBJECTIVE

- Comparing the scheduler performance of kube-batch with the scheduler performance of the default scheduler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our objective is to evaulate performance of kube-batch; it's not necessary to compare with default scheduler.


## DESIGN OVERVIEW

We assume that we want to benchmark a test T across two variants A(with default scheduler) and B(with kube-batch scheduler).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nop, only evaulate kube-batch's performance is ok.

@Rajadeepan
Copy link
Contributor Author

@k82cn updated the document as per your review comment. Does this benchmarking strategy looks fine? can i go ahead and get the benchmarking results using this strategy?

@k82cn
Copy link
Contributor

k82cn commented Mar 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2019
@k82cn
Copy link
Contributor

k82cn commented Mar 6, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, Rajadeepan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1081b2a into kubernetes-retired:master Mar 6, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants